search

SimonHalvdansson / Harmonic-HN

Modern Android client for Hacker News
https://play.google.com/store/apps/details?id=com.simon.harmonichackernews
Apache License 2.0
611 stars 40 forks source link

Fix long press triggering URL clicks in the comment body #154

Closed flofriday closed 6 months ago

flofriday commented 6 months ago

It might be that there is a more elegant solution but in my testing this works and fixes issue #114.

flofriday commented 6 months ago

I also just tested it with the swapped longpress behaivor which also works seamlessly. There a click on the url opens, the webpage and a click on on the rest of the comment opens the popup as expected.

SimonHalvdansson commented 6 months ago

Thanks! I've looked at some more proper solutions to this problem before but never managed to solve it so my elegance standards are low for this :) Much appreciated!

flofriday commented 6 months ago

Yeah, it was a little bit tricky to solve and took me longer that I would have thought, but I think it was worth the two hours and I now have a even better mental model of the codebase ;)