Open flofriday opened 6 months ago
Just want to say I have not forgotten about this, just have a lot going on research-wise at the moments but should get this merged soon! As always, thanks for your work :)
No problem, I already assumed something like that. Also this is just a side project, no need to get stressed out about it 😉.
Best of luck with your research and if you need help with anything, feel free to reach out.
PS: feel free to ignore #157 for a while, it's definitely not worth your time right now, as it doesn't add any features, is a lot of code and probably will result in a few discussions about how code look.
I added two more automatic themes for dark/light and black/light, which should address issue #118.
While this works as expected I have a couple of questions about some code pieces I stumbled upon.
API level checks
In
ThemeUtil.java
there is the following api level check just for the material theme:I don't quite get why that logic would only be necessary for that theme. Moreover, it seems faulty to me, like if we are on build level over 30 we would just not update the theme if swipeBack is disabled? Maybe I am overlooking something here.
Change auto theme naming
I currently kept your naming convention of
{theme}_daynight
for the automatic themes, however since they are not really dependent on the time but often on the system settings I thinkdynamic
orautomatic
would be a better term.As always feedback is welcome.