search

SimonHalvdansson / Harmonic-HN

Modern Android client for Hacker News
https://play.google.com/store/apps/details?id=com.simon.harmonichackernews
Apache License 2.0
611 stars 40 forks source link

Add a changelog button to the about page #163

Closed flofriday closed 5 months ago

flofriday commented 5 months ago

Previously the changelog was only displayed after and update, however it is sometimes quite handy to view the changelog to see what changed in the recent versions. Moreover I sometimes don't have the time to check the changelog when the update is released but want to read it a little bit later.

About the implementation

The text of the changelog is moved into it's own file, however the code for the popup itself is not shared. Reason for this is that the update dialog links to GitHub but such a button doesn't make sense here as the about page already has a link to GitHub.

Screen Capture:

https://github.com/SimonHalvdansson/Harmonic-HN/assets/21206831/2d571a43-43b1-4738-93af-ad29fc37973b

SimonHalvdansson commented 5 months ago

This too, is nice :)

Long term, I think Changelog.java should probably just read an actual HTML file. Not that it really matters.

flofriday commented 5 months ago

Yes, I can look into that. Honestly, I just didn't knew how much the class should do when I first wrote it, also I am not too familiar with the java build tools to know how to bundle ressource files and how to read them. But that's a great opportunity to learn that 😉