search

SimonHalvdansson / Harmonic-HN

Modern Android client for Hacker News
https://play.google.com/store/apps/details?id=com.simon.harmonichackernews
Apache License 2.0
620 stars 39 forks source link

Automatic release on tag push did not work for V1.9.6 #72

Closed streambinder closed 1 year ago

streambinder commented 1 year ago

Sorry to bother you again man, but as of https://github.com/SimonHalvdansson/Harmonic-HN/commit/63fa0a0875ccd2da43838acfd93ec57c740bdf88, pushed tags will automatically trigger a Release creation. I saw you pushed the tag for the release, but the filter was on vX.Y.Z tags (check the regex here: https://github.com/SimonHalvdansson/Harmonic-HN/blob/main/.github/workflows/tag.yml#L6C8-L6C17), and what's been pushed was capitalized (i.e. V1.9.6), so it didn't trigger the auto-release mechanism :)

SimonHalvdansson commented 1 year ago

Oh whoops my bad - I just retagged the commit and it triggered the action but only dumped the source code and didn't build an APK.

streambinder commented 1 year ago

Apparently it got build, it just wasn't put into the release:

Run softprops/action-gh-release@v1
🤔 Pattern './app/build/outputs/apk/*.apk' does not match any files.

What is the build path of the APK?

SimonHalvdansson commented 1 year ago

Looks like you found it :)