search

SimonKagstrom / kcov

Code coverage tool for compiled programs, Python and Bash which uses debugging information to collect and report data without special compilation options
http://simonkagstrom.github.io/kcov/
GNU General Public License v2.0
713 stars 109 forks source link

Fixed peek_file function to regular file only. #292

Closed kimkim19642004 closed 5 years ago

kimkim19642004 commented 5 years ago

Requirements:

Request review and merge of the following code: https://github.com/kimkim19642004/kcov/commit/936a9800dd61028e9d1fcc7c258fe18cd61aeab9#diff-40653036b0fc71e8d7ba580d5a6fb8bc

Prerequisites:

Items to check Status Evidence
Is there a basis for pull requests? Yes https://github.com/SimonKagstrom/kcov/issues/290
Have you done forking? Yes https://github.com/kimkim19642004/kcov
Have you created the branch? Yes https://github.com/kimkim19642004/kcov/tree/issue-290-utils-peek-file
Have you been tested? No I'm investigating a test environment for forked kcov.

Remarks:

I am testing with kcov in the following environment.

Signed-off-by: kimkim19642004 kimkim19642004@yahoo.co.jp

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.06%) to 70.116% when pulling 936a9800dd61028e9d1fcc7c258fe18cd61aeab9 on kimkim19642004:issue-290-utils-peek-file into b2275b259d97f5faa9af24be7cd534a254636099 on SimonKagstrom:master.

SimonKagstrom commented 5 years ago

Merged, thanks! The travis build fail seems like random errors, since only one of the four targets failed.

kimkim19642004 commented 5 years ago

I am satisfied with the results of my current mission. Thank you very much.