search

SimonKagstrom / kcov

Code coverage tool for compiled programs, Python and Bash which uses debugging information to collect and report data without special compilation options
http://simonkagstrom.github.io/kcov/
GNU General Public License v2.0
710 stars 109 forks source link

Issue #368: Handle symlinked coverage target #369

Closed rpoyner-tri closed 2 years ago

rpoyner-tri commented 2 years ago

Closes: #368

rpoyner-tri commented 2 years ago

@SimonKagstrom : feel free to use and/or improve on this patch. The test covers the situation described in #368, but could probably be improved. I was able to work out how to run the tests locally, and verified passing-with-fix, and failing-without fix.

codecov[bot] commented 2 years ago

Codecov Report

Merging #369 (d00ed59) into master (8419da5) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   63.45%   63.45%           
=======================================
  Files          57       57           
  Lines        4553     4553           
=======================================
  Hits         2889     2889           
  Misses       1664     1664
Impacted Files Coverage Δ
src/configuration.cc 54.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8419da5...d00ed59. Read the comment docs.

SimonKagstrom commented 2 years ago

Merged! Thanks for taking the time to write the regression test as well!

rpoyner-tri commented 2 years ago

Glad to be of service. Been using kcov for many years; thanks for your work on it!

SimonKagstrom commented 2 years ago

Happy to hear that, thanks a lot!