search

SimonLeclere / discord-easy-dashboard

💻 Simple module to facilitate the creation of dashboard using discord.js and express
https://www.npmjs.com/package/discord-easy-dashboard
71 stars 11 forks source link

Modals #23

Open TuckBus opened 2 years ago

TuckBus commented 2 years ago

Adds bootstrap modals that can have the same settings that the base dashboard can. Tested and works fine for me. I requested this in #22 and got bored so I decided to add it.

HeCodes2Much commented 2 years ago

modals should be done within the theme itself not this way but that's just my 2 cents this will also break 99% of bots and themes if they don't change there code with the way you now have Dashboard.Dashboard when you could of just left that was it was and added Modal without the dashboard infont :)

TuckBus commented 2 years ago

Fair enough, but it shouldn't be too hard to change it, you'd just need to destructure Modal and Dashboard. Just two curly braces should fix it if they have it set up like in the Getting Started example.

SimonLeclere commented 2 years ago

Fair enough, but it shouldn't be too hard to change it, you'd just need to destructure Modal and Dashboard. Just two curly braces should fix it if they have it set up like in the Getting Started example.

+1 and people who already use the module will use the previous version until they update it so it's not really a problem I think. I prefer to release breaking updates when the module is small than when many developers are using it.

SimonLeclere commented 2 years ago

Hey, why is the modal section commented in the index.d.ts file ?

TuckBus commented 2 years ago

Hey, why is the modal section commented in the index.d.ts file ?

That was a mistake, didn't even realize it was commented out when I was committing. I'll fix it in a few hours when I can get to my computer.

TuckBus commented 2 years ago

Hey, why is the modal section commented in the index.d.ts file ?

That was a mistake, didn't even realize it was commented out when I was committing. I'll fix it in a few hours when I can get to my computer.

SimonLeclere commented 2 years ago

Okay cool, I'll merge it later. Thanks a lot for your contribution

SimonLeclere commented 1 year ago

ups I forgot this one