SimonM0 / ghost-static-site-generator

Generate a static site from ghost and deploy using a CI
https://github.com/Fried-Chicken/ghost-static-site-generator
MIT License
316 stars 42 forks source link

Page not being included #7

Closed Stono closed 5 years ago

Stono commented 5 years ago

Hey, I use formspree for "contact me" https://karlstoney.com/contact - which upon success redirects back to https://karlstoney.com/thanks.

/thanks exists in ghost as a page but it isn't being included in my static site content.

You can see it in my sitemap here: https://karlstoney.com/sitemap-pages.xml

Not sure what's going wrong, any ideas?

SimonM0 commented 5 years ago

Hey @Stono

I've thought about this before briefly. So it's not included because there are no links to this page on the site anywhere. I did think of adding a flag before, but then it's just too many flags. I'm thinking I could add a .gssgconfig where you can add all the settings and just run gssg instead.

What do you think?

Stono commented 5 years ago

Sounds like a great idea in general, but for this specific issue couldn't you also traverse the sitemap.xml to ensure you're indexing all pages?

On Sat, 5 Jan 2019, 4:08 pm Simon Mo <notifications@github.com wrote:

Hey @Stono https://github.com/Stono

I've thought about this before briefly. So it's not included because there are no links to this page on the site anywhere. I did think of adding a flag before, but then it's just too many flags. I'm thinking I could add a .gssgconfig where you can add all the settings and just run gssg instead.

What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fried-Chicken/ghost-static-site-generator/issues/7#issuecomment-451667619, or mute the thread https://github.com/notifications/unsubscribe-auth/ABavidTD95J1qMBEZB5zt_Q2lvYADv5Nks5vAM3vgaJpZM4ZxfrF .

SimonM0 commented 5 years ago

That's a good idea, I think traversing the sitemap's better. Let me have a go at that.

Stono commented 5 years ago

Confirmed this is fixed

SimonM0 commented 5 years ago

Awesome