SimonSimCity / Xamarin-CrossDownloadManager

A cross platform download manager for Xamarin
MIT License
149 stars 68 forks source link

Download completion notification not showing in android #99

Closed Sarthak261995 closed 5 years ago

Sarthak261995 commented 5 years ago

To help us fix your issue, please provide the information in the below template.

Note: If you want to save time, please create a fork, reproduce the bug in the sample projects and add a link to the repository here.

Steps to reproduce

  1. When the file is downloading progress is showing in android notification bar .But when completed notification of that downloaded file hides.It should be still there with text download completed with file name like every browser does,doesn't it.I am using this plugin in xamarin forms app.

  2. I have wrote this (CrossDownloadManager.Current as DownloadManagerImplementation).IsVisibleInDownloadsUi = true; in my MainAcitivity class but it showing notification only while file is downloading.I want file completion notification too.

3.I know android download manager have some method like something setCompletionNotificatoin = Visiblity.Visible can anyone know how to do that This will be very helpful

Expected behavior

Notification should be still there like download completion text.

Actual behavior

Notification hides when file download completed in android.

Configuration

Platform:

Device:

SimonSimCity commented 5 years ago

I have wrote this (CrossDownloadManager.Current as DownloadManagerImplementation).IsVisibleInDownloadsUi = true; in my MainAcitivity class but it showing notification only while file is downloading.I want file completion notification too.

Well, this isn't about notification, but about the app Downloads - as you can see from the Android specification: https://developer.android.com/reference/android/app/DownloadManager.Request#setVisibleInDownloadsUi(boolean)

And as an additional hint: You can also set this value without the cast.

To me it looks like you want an implementation of https://developer.android.com/reference/android/app/DownloadManager.Request.html#setNotificationVisibility(int) - well, this is possible at CrossDownloadManager.Current .NotificationVisibility.

I have to set up a documentation for all this somewhere ... and maybe the wiki is a better place than extending the readme.

Does this answer your question?

Sarthak261995 commented 5 years ago

I am just trying to say the download manager progress bar hides once file download completed it should stay saying something like download complete with file name . whatever you answered is not even a bit related to my query On 13 Nov 2018 13:19, "Simon Schick" notifications@github.com wrote:

I have wrote this (CrossDownloadManager.Current as DownloadManagerImplementation).IsVisibleInDownloadsUi = true; in my MainAcitivity class but it showing notification only while file is downloading.I want file completion notification too.

Well, this isn't about notification, but about the app Downloads - as you can see from the Android specification: https://developer.android.com/ reference/android/app/DownloadManager.Request#setVisibleInDownloadsUi( boolean)

And as an additional hint: You can also set this value without the cast.

To me it looks like you want an implementation of https://developer.android.com/reference/android/app/ DownloadManager.Request.html#setNotificationVisibility(int) - well, this is possible at CrossDownloadManager.Current .NotificationVisibility.

I have to set up a documentation for all this somewhere ... and maybe the wiki is a better place than extending the readme.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/issues/99#issuecomment-438168811, or mute the thread https://github.com/notifications/unsubscribe-auth/AoVoTnVLV9r8dtufF8qAKgaK_Ld_zpL2ks5uunlsgaJpZM4YX3qs .

amitkumar15 commented 5 years ago

Want to show something like this screen shot 2018-11-15 at 1 41 40 pm

amitkumar15 commented 5 years ago

same as above guy problem download manager progress bar hides as soon as file completes downloading

Sarthak261995 commented 5 years ago

Can you add request.SetNotificationVisibility(DownloadVisibility. VisibleNotifyCompleted); in your android download manager implementation it will solve my problem.

On Thu, 15 Nov 2018 at 13:44, amitkumar15 notifications@github.com wrote:

same as above guy problem download manager progress bar hides as soon as file completes downloading

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/issues/99#issuecomment-438954313, or mute the thread https://github.com/notifications/unsubscribe-auth/AoVoTsJZFN5GLuyzyRDwhwF3cGx_lg0Tks5uvSJugaJpZM4YX3qs .

SimonSimCity commented 5 years ago

No, but you can adjust this value yourself, as I wrote previously.

You need to set CrossDownloadManager.Current .NotificationVisibility to the value you want it to be at before adding the file to the queue.

I've also had a sample available of how to use it:

https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/blob/6685970175024cb3f5fec7ce720f540f8487e36a/Sample/Droid/MainActivity.cs#L24-L27

I won't set fixed values, just because you need it for your project, but keep it configurable that everyone can set the value he needs.

... being a bit more polite in the way of writing wouldn't harm either ...

angelnmara commented 5 years ago

Can you add request.SetNotificationVisibility(DownloadVisibility. VisibleNotifyCompleted); in your android download manager implementation it will solve my problem. On Thu, 15 Nov 2018 at 13:44, amitkumar15 @.***> wrote: same as above guy problem download manager progress bar hides as soon as file completes downloading — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#99 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AoVoTsJZFN5GLuyzyRDwhwF3cGx_lg0Tks5uvSJugaJpZM4YX3qs .

thanks man, mi descarga era muy rápida entonces no se visualizaba nada, con la opción VISIBILITY_VISIBLE_NOTIFY_COMPLETED This download is visible and shows in the notifications while in progress and after completion. Entonces ya lo puedo visualizar en mi barra de notificaciones, muchas gracias, sufrí mucho!