SimonVT / android-menudrawer

*DEPRECATED* A slide-out menu implementation, which allows users to navigate between views in your app.
http://simonvt.github.com/android-menudrawer/
Apache License 2.0
2.59k stars 1.11k forks source link

Bottom drawer in window-drag mode top padding defect. #206

Closed soarcn closed 10 years ago

soarcn commented 10 years ago

Hi Simon, Thanks for your excellent library. There is a defect when using Bottom drawer in window-drag mode. The root cause is at MenuDrawer.java line 1479

I made a quick patch for this.

@Override
protected boolean fitSystemWindows(Rect insets) {
    if (mDragMode == MENU_DRAG_WINDOW) {
        if (mPosition==Position.BOTTOM)
            mMenuContainer.setPadding(0, 0, 0, 0);
        else
            mMenuContainer.setPadding(0, insets.top, 0, 0);
    }
    return super.fitSystemWindows(insets);
}

BTW: could you please continue support apklib (maven)?

Thanks!

SimonVT commented 10 years ago

Makes sense, fixed on master :)

I'm not going to be releasing any more apklibs. It's up to the android maven plugin to support aars.

dant3 commented 10 years ago

Android maven plugin now fully supports aars (version 3.8.1 is out)