search

SimonVT / android-menudrawer

*DEPRECATED* A slide-out menu implementation, which allows users to navigate between views in your app.
http://simonvt.github.com/android-menudrawer/
Apache License 2.0
2.59k stars 1.11k forks source link

Removes ActionBarSherlock and adds in support for the appCompat library. #222

Closed abeatte closed 10 years ago

abeatte commented 10 years ago

ActionBarSherlock and ActionBarCompat are mutually exclusive so they cannot exist side by side. This required removing ABS for the more supported ABC library. To support ABC with pre ICS devices you need to search for R.action_bar_activity_content as opposed to android.R.id.content to inject views.

DHuckaby commented 10 years ago

Some legacy applications still run ABS. I see the value in adding a sample for ABC but replacing the old one might be a bit excessive in my opinion.

abeatte commented 10 years ago

Android does not allow for custom attributes to be defined more than once. This is (one of the reasons) why ActionBarSherlock and ActionBarCompat are mutually exclusive. That coupled with the fact that @JakeWharton has already stated that he is no longer going to support ABS it made most sense to me to remove ABS to make way for ABC which will have continuing support. I would love to have them both side by side (really only useful for a proof-of-concept app like this) if someone wanted to figure out how to swap out the custom attrs on the fly.

SimonVT commented 10 years ago

I'm not really interested in removing the ABS sample. You can submit a pull request that checks for the appcompat id if you want, as long as it only happens on < api14.