search

SimonbJohnson / quickX3

HXLDash. Create data visualisations quickly by leveraging the humanitarian exchange language
https://hxldash.com/
MIT License
8 stars 4 forks source link

Replace rawgit resources #65

Closed SimonbJohnson closed 4 years ago

SimonbJohnson commented 4 years ago

Rawgit could close down at anytime. Migrate files referenced there: https://rawgit.com/

fititnt commented 4 years ago

Maybe from this:

https://github.com/SimonbJohnson/quickX3/blob/5e21b5a59232dae25bd25eb9835d52447f384de8/hxldash/templates/base/base.html#L33-L35

To this:

<script src="https://unpkg.com/chartist-plugin-legend@0.6.2/chartist-plugin-legend.js"></script> 
 <script src="{% static 'libs/chartist-plugin-tooltip.js' %}"></script> 
 <link rel="stylesheet" type="text/css" href="https://unpkg.com/chartist-plugin-tooltips@0.0.17/dist/chartist-plugin-tooltip.css" />

One problem I found is that https://rawgit.com/CodeYellowBV/chartist-plugin-legend/master/chartist-plugin-legend.js is not the same as the https://unpkg.com/chartist-plugin-legend@0.6.2/chartist-plugin-legend.js.

Here the quick diff of these files https://www.diffchecker.com/NLSdkzuu.

The reason for this difference (I did not tested if it could break the interface, so at this point will not just send a PR) seems to be the did not released a version and then pushed to NPM, so the unpkg.com will point to the old release without these new commits https://github.com/CodeYellowBV/chartist-plugin-legend/compare/v0.6.2...master.

SimonbJohnson commented 4 years ago

Fixed https://github.com/SimonbJohnson/quickX3/pull/77