SimonbJohnson / quickX3

HXLDash. Create data visualisations quickly by leveraging the humanitarian exchange language
https://hxldash.com/
MIT License
8 stars 4 forks source link

[a11y] Explicitly set the default language of the page to English (e.g. from `<html>` to `<html lang="en">`) #73

Closed fititnt closed 4 years ago

fititnt commented 4 years ago

Refs:


The default behavior of the hxldash at this moment is not explicitly set the language of the document, and this result in failing an accessibility test. My suggestion at the moment is explicitly change the <html> to <html lang="en"> on the entire site (even on the dashboards page) that may have mixed content to pass these accessibility tests. (Maybe is at this line https://github.com/SimonbJohnson/quickX3/blob/master/hxldash/templates/base/base.html#L5)

I will open other 1~2 issues on some corner cases. But this issue is likely to be a quick one.


Why

By not explicitly setting the language, screen reader users that by default use other languages (even if they understand English) will hear their screen readers speak English with an different voice.

One way to simulate this is going to google translate page, putting something in English but asking random languages to speak aloud.

SimonbJohnson commented 4 years ago

Fixed https://github.com/SimonbJohnson/quickX3/pull/77