Closed cristiangreco closed 4 years ago
@SimoneTinella thanks for accepting the PR! Let me know if you have any feedback.
PS: note that in case you want to always point PRs from the action to a non-default branch (e.g. dev
) you can use the target-branch
input.
Hey there 👋, first of all thanks for your work on this app!
I've got a suggested change: would you be willing to use this GitHub Action to automatically keep Gradle Wrapper updated to latest release?
What does "Update Gradle Wrapper Action" do? It can be configured to run at scheduled intervals (e.g. daily or weekly) and will check whether the Wrapper script in the repo is up-to-date to the latest Gradle release: in case a new Gradle version is available, it will create a PR to update the Wrapper. And that's it!
Why is that a good thing? Well, first of all it alleviates the chore of manually updating the Wrapper, as you got a task that keeps track of new Gradle releases for you! More importantly, it boosts security around the Wrapper update and usage processes: this actions verifies that the
gradle-wrapper.jar
file has not been tampered with (uses checksum comparison), and it sets thedistributionSha256Sum
property so that the new Gradle binary itself will be verified locally upon download.Where can I find more about? The README contains quite detailed information!
In this PR I propose adding a new workflow which runs the action every day at midnight (but feel free to adjust the frequency as you prefer). I've verified it works correctly in my fork of the repo, and you can see here how the generated PR looks like.
The action is under active development, you can have a look at the list of inputs currently supported. There's new features coming up soon and if you'd like to request any particular change just let me know!
I'd love to see the action used your app as it would definitely help me spread the word, but I also genuinely hope you can find this useful. Would love your feedback! ❤️