Reloading Inconsistent Entities - Githubissues

Simperium / simperium-ios

Simperium libraries and samples

MIT License

206 stars 43 forks source link

Reloading Inconsistent Entities #585

Closed jleandroperez closed 4 years ago

jleandroperez commented 4 years ago

Details:

In this PR we're adding an error handling mechanism, capable of detecting Ghost(s) in inconsistent states, and triggering a full entity re-download.

cc @bummytime cc @dmsnell

Closes #584

Testing:

Check out Simplenote iOS
Map Simperium's dependency to commit bbcbc91 (this branch, latest!)
Comment out DiffMatchPach.m L1510 thru L1528
Clean + Rebuild
Log into your account
Add a new note
Insert the following emojis: ☺️🖖🏿
Insert the following emoji in between: 😃

[x] Verify Simplenote does not crash
[ ] Verify that (after a second) you end up with ☺️😃(null)🖖🏿 onscreen

Note:

The purpose of this fix is to prevent the app from entering a crashloop, caused by NSJSONSerialization while attempting to serialize a broken string, and recover by performing a full entity re-download
The actual underlying bug has been already fixed via #583 and #582

jleandroperez commented 4 years ago

Thank you for testing this one Bummy!!