search

SimplGy / obsidian-emoji-magic

Makes it easier to add emojis using an improved keyword search
Apache License 2.0
18 stars 1 forks source link

Popup closed immediately, if command selected with Enter key. #5

Closed mii-key closed 1 year ago

mii-key commented 1 year ago

Windows 10 x64, Obsidian 1.2.7 Emoji Magic: 0.2.1

Steps to reproduce

  1. Open command palette
  2. Type 'emoji' to select 'Emoji Magic: Insert emoji...' command
  3. Press Enter

Expected result: the popup is displayed.

Actual result: the popup appears for a moment and then closes.

If a command is selected with a mouse click, the popup appears as expected.

bug

SimplGy commented 1 year ago

Well that is very interesting. Thanks for the detailed and wonderful bug report. I bet you were a good student in school.

I wonder if this is the same problem for all windows users.

Does it work once you assign a keyboard shortcut?

On Mon, May 8, 2023 at 12:53 PM mii-key @.***> wrote:

Windows 10 x64, Obsidian 1.2.7 Emoji Magic: 0.2.1

Steps to reproduce

  1. Open command palette
  2. Type 'emoji' to select 'Emoji Magic: Insert emoji...' command
  3. Press Enter

Expected result: popup displayed

Actual result: popup appears for a moment, and t hen closes.

If command selected with mouse popup appears as expected.

[image: bug] https://user-images.githubusercontent.com/130221089/236920324-aa837e2f-0257-4989-a6af-448a37e0ea59.gif

— Reply to this email directly, view it on GitHub https://github.com/SimplGy/obsidian-emoji-magic/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEF7SMD6BASNJFMLJD5FFDXFFFMPANCNFSM6AAAAAAX2L7PVE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fmeulenk commented 1 year ago

I got the same Bug under Fedora 37, Obsidian 1.2.7 and Emoji Magic 0.2.1.

If I use the command palette, the dialog closes instantaneously, barely to see.

I assigned a Hotkey afterwards. Then it works with the Hotkey, but still not via the command palette.

mii-key commented 1 year ago

Well that is very interesting. Thanks for the detailed and wonderful bug report. I bet you were a good student in school. I wonder if this is the same problem for all windows users. Does it work once you assign a keyboard shortcut? … On Mon, May 8, 2023 at 12:53 PM mii-key @.> wrote: Windows 10 x64, Obsidian 1.2.7 Emoji Magic: 0.2.1 Steps to reproduce 1. Open command palette 2. Type 'emoji' to select 'Emoji Magic: Insert emoji...' command 3. Press Enter Expected result: popup displayed Actual result: popup appears for a moment, and t hen closes. If command selected with mouse popup appears as expected. [image: bug] https://user-images.githubusercontent.com/130221089/236920324-aa837e2f-0257-4989-a6af-448a37e0ea59.gif — Reply to this email directly, view it on GitHub <#5>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEF7SMD6BASNJFMLJD5FFDXFFFMPANCNFSM6AAAAAAX2L7PVE . You are receiving this because you are subscribed to this thread.Message ID: @.>

With a hotkey works fine.

SimplGy commented 1 year ago

Looking now. Can repro, very strange. One oddity is that even when using the mouse to select from command palette, it "works", but not the recent emoji; which isn't what I'd expect either...

SimplGy commented 1 year ago

Found the problem; delicate interaction on keydown/keyup between the app and the plugin, very interesting. fixed by https://github.com/SimplGy/obsidian-emoji-magic/commit/db3b73b5b8977b06a3e67279dfe4c35d0d94ee91

SimplGy commented 1 year ago

Update to 0.2.2 to resolve.