SimplGy / obsidian-emoji-magic

Makes it easier to add emojis using an improved keyword search
Apache License 2.0
18 stars 1 forks source link

Improve ranking - doesn't always update on search term edit + prioritize exact matches #8

Open redactedscribe opened 1 year ago

redactedscribe commented 1 year ago

For example, typing cart then deleting the t doesn't return results for car. Additionally, car doesn't return cars first but cat emojis instead (if a space is added after car then the search term is more accurate).

Ideally results should update on every edit of the search term, and also prioritise exact and partial exact matches before similar matches, e.g. for car: šŸš“ ("police car"), then other [emojis with car as a whole word in their name], then [emojis with car as a partial exact match, e.g. šŸ›’ ("shopping cart")], then [emojis named similarly similar using some fuzzy matching, e.g. šŸˆ ("cat").

Thanks.

Edit: I guess the inaccuracy of emoji results stems from being able to search for e.g. "green" for green coloured emojis without green being in their name. Maybe matches beyond emoji names should be ranked after partial exact matches, so before fuzzy matches?

SimplGy commented 1 year ago

This is a really high quality report, thanks for filing it.

When I get a chance Iā€™d love to take a look at some of these examples and improve how they are handled.

On Mon, Sep 18, 2023 at 7:30 AM redactedscribe @.***> wrote:

For example, typing cart then deleting the t doesn't return results for car. Additionally, car doesn't return cars first but cat emojis instead (if a space is added after car then the search term is more accurate).

Ideally results should update on every edit of the search term, and also prioritise exact and partial exact matches before similar matches, e.g. for car: šŸš“ ("police car"), then other [emojis with car as a whole word in their name], then [emojis with car as a partial exact match, e.g. šŸ›’ ("shopping cart")], then [emojis named similarly similar using some fuzzy matching, e.g. šŸ˜ŗ ("cat").

Thanks.

ā€” Reply to this email directly, view it on GitHub https://github.com/SimplGy/obsidian-emoji-magic/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEF7SIL72ZRNRF6XIAH3S3X3BLKHANCNFSM6AAAAAA442K7XM . You are receiving this because you are subscribed to this thread.Message ID: @.***>