Fix and reuse the page layout across all pages

SimplQ / simplQ-frontend

Modern and fully web based free queue management open source software.

https://simplq.me

GNU General Public License v3.0

176 stars 135 forks source link

Fix and reuse the page layout across all pages #490

Open daltonfury42 opened 3 years ago

daltonfury42 commented 3 years ago

We should standardise and reuse a common layout across all pages. We have four main pages: Home, Admin, Join and Status. The general layout of all the four pages are like this:

Currently each page has its own layout defined inside it. We should solve it at one place and reuse it across.

Open Question: What should be the approach? Flexbox vs Grid.

mradenovic commented 3 years ago

With grid very complex layout can be achieved. With flexbox the simplest approach would be to make all sections equal within the main content.

Large screen Large Medium screen Medium Small screen Small

daltonfury42 commented 3 years ago

We need the flex-wrap style in where sections automatically wrap properly so that the same page works without much issues on both desktop and mobile.

mradenovic commented 3 years ago

We need the flex-wrap style in where sections automatically wrap properly so that the same page works without much issues on both desktop and mobile.

This is gonna be much easier to do once we are done with #492 and #516.

prabureddy commented 3 years ago

@daltonfury42 We already using Layout Component in all pages right if I'm not wrong? I don't see any issue here. I think I don't understand this issue. Can you please explain this a bit more.

daltonfury42 commented 3 years ago

We style the layout of each page independently. We should define some common css classes and reuse it across all pages, for the general page layout.

@mradenovic Do you have something else in mind?

shashank1503-cipher commented 3 years ago

we can use flex-wrap

NereidaRondon commented 2 years ago

Hello, I would love the opportunity to work on converting the pages to CSS grid. Can I be assigned this issue? 😁

daltonfury42 commented 2 years ago

This project is not being actively maintained anymore. Thanks for offering the help!

On Wed, 5 Oct 2022 at 9:46 PM, Nereida Rondon @.***> wrote:

Hello, I would love the opportunity to work on converting the pages to CSS grid. Can I be assigned this issue? 😁

— Reply to this email directly, view it on GitHub https://github.com/SimplQ/simplQ-frontend/issues/490#issuecomment-1268648404, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACV4EOEWXGQYU6YNHTNU4V3WBWSWJANCNFSM4WS7ZZTQ . You are receiving this because you were mentioned.Message ID: @.***>

nehagupta1504 commented 8 months ago

I would like to work on the pages to create a global layout which can be reused just like an HOC.