Solved ScrollTo in Window Issue #636, Implemented the Code for History Queue #601 and Integrated QR code scanning Issue #471

Soumit915 commented 3 years ago

This fixed issue #636 , provides frontend support for #601 and integrated QR code scanning issue #471 . The PR consists of:

[x] Previously, #636 occured, as Safari doesn't supports the API, Window.scrollTo(option-json). As a result, I, at first, did handle the Safari cases seperately. However, later I implemented an all in one solution and I think it will work. As, now I am passing 2 params for Window.scrollTo, and it won't be an issue as it is supported in Safari. Please confirm me, if the issue gets resolved.
[x] Provided frontend support for a responsive Queue History #601 . Do need some backend support, with the API format mentioned in Backend Support. For now, I have implemented the Queue History for a static data, the dataset is present in src/data for your reference. Once the api-route is created from the backend, we can just link the data-fetcher to the api-route instead of the dataset.
[x] Integrated QR code scanning issue #471 . Created a button in home page that will redirect to /scanQr route and you can scan any QR code which will then redirect you to target url. Haven't put any condition or any constraint on what the url can be, but you can please update me with the constraints if any, so that I can apply and update it accordingly. The scanning can be done with even your computer or laptop if you have a valid camera device. For mac users or safari customers, where scanning is an issue, the app takes captures images of the qr-code and then processes it. However, the users need not to worry anything about it as the process for a mac-user is same as that of any user using any other device.
Glimpse of the frontend ui, implemented.
[x] I have also re-added the pause queue, functionality which was previously muted.

daltonfury42 commented 3 years ago

@Soumit915 Someone has commented on the issue before you did, and had also raised a PR https://github.com/SimplQ/simplQ-frontend/pull/646

I feel it's good to respect her effort, help get that PR merged (both of you will learn from it), and then make changes on top of it.

Soumit915 commented 3 years ago

@Soumit915 Someone has commented on the issue before you did, and had also raised a PR #646

I feel it's good to respect her effort, help get that PR merged (both of you will learn from it), and then make changes on top of it.

@daltonfury42 , its absolutely fine. You please merge that PR, I will then update things on top of it.

Soumit915 commented 3 years ago

Thanks a lot for the PR, I've added my thoughts inline. The UI looks nice.

But there's an error that comes up on chrome if I try to click the next page button. Do take a look.

@maaverik , from my end it looks absolutely ok and fine and btw I have not implemented the function onChangePage, instead I have implemented onPageChange.

Did you run npm install before running my code? As I have updated the version of@materials-ui/coreto the latest stable version as the previous version was having some problems. @maaverik , can you please confirm this?

Soumit915 commented 3 years ago

@maaverik , as told by you, I have made the changes in b6285742098857025f1f13ada55f236c7177547c , and refactored code and added back the brackets as mentioned by you. I have also implemented things by functional component as mentioned by you instead of class components.

Please do review and confirm the changes.

From my side the next-page button works perfectly fine, please confirm about whether you have ran, npm install, as I have updated the version of @material-ui/core to the latest stable version.

@daltonfury42 , it absolutely fine to merge PR #646 . Please do merge it so that I can update on top of it and successfully finish this issue and go on with the other issues.

On #636 , please confirm me, as whether it is working or not

Soumit915 commented 3 years ago

@maaverik as requested by you, I have made the changes in my latest commit. I was unaware of some facts at the beginning of the start of this project, which I have now been acquainted with. I am extremely sorry for that.

I also integrated the QR code scanning issue #471 . Please leave your thoughts reviewing it.

@daltonfury42 , can you please implement the /queue/events route then we can move forward with the final implementation of the Queue-History.

daltonfury42 commented 3 years ago

@Soumit915 You have done a lot of good things in the PR, thank you for that. I will try to do the API sometime this week, but at max by the coming weekend. I have gotten very busy with some other unexpected work, hence the delay, extremely sorry about this.

Soumit915 commented 3 years ago

I see the name of the queue changes and becomes capitalised in the pop-up of the qr-code. I think there might be miss-understanding arising with the name of the queue, when there are alike names like 'MyQ1' and 'Myq1'. Even, when the queue remains empty this thing happens. This might lead to confusion to the users as to which queue is the one they are wanting. I have attached the screenshots of the case below.

The above two queues are different but the same name is getting displayed. Either we should refrain from using duplicate queue-names irrespective of the case of the letters or we should display the queue names without capitalising them.

@daltonfury42 @maaverik , can you please confirm about the senario.

maaverik commented 3 years ago

@Soumit915 finally tested the next button in the history pane again, no issues this time, the problem last time must have been due to an outdated package. The scan QR also seems okay. Once you get some time to convert QrScanner also to a functional component, this PR will be ready to merge.

@daltonfury42 is the master branch not getting deployed to the dev.simplq.me site now? I don't see the effect of the last push on there.

Soumit915 commented 3 years ago

@Soumit915 finally tested the next button in the history pane again, no issues this time, the problem last time must have been due to an outdated package. The scan QR also seems okay. Once you get some time to convert QrScanner also to a functional component, this PR will be ready to merge.

@daltonfury42 is the master branch not getting deployed to the dev.simplq.me site now? I don't see the effect of the last push on there.

@maaverik , thanks a lot. I have resolved the issues you have mentioned.

Soumit915 commented 3 years ago

@maaverik , thanks a lot for the merge.

@daltonfury42 , I am still looking forward to contribute to the left-over implementation of Queue-History. As soon as the backend implementation is done, please notify me so that I can finish the with it.

@maaverik , @daltonfury42 , if you feel issues #636 and #471 is solved can we close them?

I am also looking forward to make the scanQr-ui better. If you have any ideas do share.

daltonfury42 commented 3 years ago

Hey, sorry for the long delay, it's been done, please test and let me know if there are any issues. Sample request:

curl 'https://devbackend.simplq.me/v1/queue/6e6d2f3e-4960-40f9-b771-72c5a77ce7f6/events' \
  -H 'Connection: keep-alive' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Authorization: Anonymous anonymous-bebb07d8-26fa-4bb2-bc1d-c347267efc7d' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.58 Safari/537.36' \
  -H 'Sec-GPC: 1' \
  -H 'Origin: https://www.simplq.me' \
  -H 'Sec-Fetch-Site: same-site' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Referer: https://www.simplq.me/' \
  -H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \
  --compressed

Soumit915 commented 3 years ago

Hey, sorry for the long delay, it's been done, please test and let me know if there are any issues. Sample request:

curl 'https://devbackend.simplq.me/v1/queue/6e6d2f3e-4960-40f9-b771-72c5a77ce7f6/events' \
  -H 'Connection: keep-alive' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Authorization: Anonymous anonymous-bebb07d8-26fa-4bb2-bc1d-c347267efc7d' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.58 Safari/537.36' \
  -H 'Sec-GPC: 1' \
  -H 'Origin: https://www.simplq.me' \
  -H 'Sec-Fetch-Site: same-site' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Referer: https://www.simplq.me/' \
  -H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \
  --compressed

@daltonfury42 As for now, there are no issues faced. I have implemented it and had done a PR. PR #649

Soumit915 commented 3 years ago

@daltonfury42 , @maaverik can you close #636 and #471, if you feel it is resolved?

SimplQ / simplQ-frontend

Solved ScrollTo in Window Issue #636, Implemented the Code for History Queue #601 and Integrated QR code scanning Issue #471 #647