returned expression instead of assigning to temporary variable response

[maaverik]

Hi @divyansh21jain, thanks for the PR. This is purely my opinion, but I prefer assigning the response to a temporary variable before returning a tad bit more readable than directly returning. @daltonfury42 if you think directly returning the expression is better, we can go that route.

[daltonfury42]

Yeah, I think it depends on context. I am not having a strong argument against it, so I’ll say keep the variable. Readability wins.

On Fri, 10 Sep 2021 at 12:19 AM, Nithin @.***> wrote:

Hi @divyansh21jain https://github.com/divyansh21jain, thanks for the PR. This is purely my opinion, but I prefer assigning the response to a temporary variable before returning a tad bit more readable than directly returning. @daltonfury42 https://github.com/daltonfury42 if you think directly returning the expression is better, we can go that route.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/SimplQ/simplQ-frontend/pull/650#issuecomment-916350384, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACV4EOEYHDIG4VZ6YJJTUBDUBD6THANCNFSM5DUPZO5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[maaverik]

Closing since we decided to leave it the old way. @divyansh21jain thanks for trying, feel free to take up any other issue that interests you.