Closed daltonfury42 closed 2 years ago
Hello there @daltonfury42 ! If this issue is still open, then I would like to be assigned and try to contribute on this one. Just please let me know. Best regards
Sure, go ahead and raise a PR. Let us know if there are any doubts.
On Sun, 3 Oct 2021 at 4:11 PM, danielvydra @.***> wrote:
Hello there @daltonfury42 https://github.com/daltonfury42 ! If this issues is still open, then I would like to be assigned and try to contribute on this one. Just please let me know. Best regards
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SimplQ/simplQ-frontend/issues/653#issuecomment-932915588, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACV4EOAPETX4SDSA4365EWLUFAXMJANCNFSM5EOZTJUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Hi @daltonfury42 , I saw that it automatically popup snackbar when error occures in API response. Shall I render that message in 3.c regardless (resulting in 2 messages) or only keep API message? I would have better control over it using pure axios. Anyway I am almost done with this task.
Shall I render that message in 3.c regardless (resulting in 2 messages) or only keep API message
You can do what you think is the cleanest and easiest to do. Then we can do follow up PRs if UX improvement is required.
I would have better control over it using pure axios.
Let us not go this route though.
Create a queue, then go to queue settings and enable "Self Join".
Now, visiting the queue joining link (example link) will take the user to the joining page which currently looks like this:
Currently it asks for both name and mobile number in one go. We need to split it into two steps:
selfJoinAllowed
, ask user for his name. On clicking on "Join", create the token and then take the user to the token status page. c. If token not present against the phone number, andselfJoinAllowed
is false, render a message "Sorry, token doesn't exist in the queue, please check with the queue operator".This imporved user flow would require us to refactor this component.