Closed danielvydra closed 2 years ago
@daltonfury42 I am sorry, by mistake I messed up my branch. On the other hand, I made fix and refactoring based on your tips 🙂 Hope will be okay.
No worries. I will review in 10-12 hours.
Before I review, can you run eslint on your branch and fix any leftover errors for changes you made:
npm i -g eslint
cd simplq/
eslint --fix
Sure, I run that - no errors, everything seems to be working fine.
I was expecting it to auto format these white spaces etc, can you check once more?
Well, IntelliJ Webstorm automatically add 4-space indent (which is common thing I think) and after running eslint I got "found 0 vulnerabilities". Previously there was only 2-space indent.
@maaverik Sajmal badly wants this feature. I am merging. Please leave any comments if you have, and I or Daniel can take it up as a follow up PR.
@danielvydra Good job on the PR, happy hacking!
Cool, thank you! I am new to open source contribution and like this project. 🙂
Creating additional pull request after solving created issue #653
This new PR:
Old PR:
666
Feel free to review changes @daltonfury42 All should be fine now Hope can be merged