SimplQ / simplQ-frontend

Modern and fully web based free queue management open source software.
https://simplq.me
GNU General Public License v3.0
175 stars 135 forks source link

Additional PR for Issue #653 #667

Closed danielvydra closed 2 years ago

danielvydra commented 2 years ago

Creating additional pull request after solving created issue #653

This new PR:

Old PR:

Feel free to review changes @daltonfury42 All should be fine now Hope can be merged

danielvydra commented 2 years ago

@daltonfury42 I am sorry, by mistake I messed up my branch. On the other hand, I made fix and refactoring based on your tips 🙂 Hope will be okay.

daltonfury42 commented 2 years ago

No worries. I will review in 10-12 hours.

Before I review, can you run eslint on your branch and fix any leftover errors for changes you made:

npm i -g eslint
cd simplq/
eslint --fix 
danielvydra commented 2 years ago

Sure, I run that - no errors, everything seems to be working fine.

daltonfury42 commented 2 years ago

I was expecting it to auto format these white spaces etc, can you check once more?

image

danielvydra commented 2 years ago

Well, IntelliJ Webstorm automatically add 4-space indent (which is common thing I think) and after running eslint I got "found 0 vulnerabilities". Previously there was only 2-space indent.

daltonfury42 commented 2 years ago

@maaverik Sajmal badly wants this feature. I am merging. Please leave any comments if you have, and I or Daniel can take it up as a follow up PR.

@danielvydra Good job on the PR, happy hacking!

danielvydra commented 2 years ago

Cool, thank you! I am new to open source contribution and like this project. 🙂