Closed ManifoldFR closed 4 months ago
Great achievement @ManifoldFR! Bravo!
Adding this comment here for future reference (it'll be added to the docs)
At time of writing, in the current master branch of Eigen (3.4.90), the global variable which tracks whether allocations are allowed is thread-safe: https://gitlab.com/libeigen/eigen/-/blob/master/Eigen/src/Core/util/Memory.h#L96
But on released versions of Eigen it is NOT, hence any check for mallocs when multithreading is enabled will break as on/off switches for the malloc status will create race conditions.
@edantec
@jorisv @edantec @fabinsch you guys think we can merge this bad boy ?
This PR:
gar
to factorize LQ subproblems for solvers (Resolves #118, @ManifoldFR )gar
(Resolves #148)gar
solversLogger
class (rename fromBaseLogger
)I would like to thank the contributors to this PR: @fabinsch, @edantec, @jorisv
Resolves #155