Simple-Station / Einstein-Engines

Nobody will ever notice I changed the repository description, right?
GNU Affero General Public License v3.0
54 stars 147 forks source link

Custom Species Name disappears after switching race, when disabled in the prototype #1101

Open DangerRevolution opened 3 weeks ago

DangerRevolution commented 3 weeks ago

Reproduction

Enter the Character UI Swap race

Expected behavior

It doesn't do that

Media

https://github.com/user-attachments/assets/801c1f74-3d3b-4f20-8760-715cf315e688

This happens whether or not you input any text. This does not return if you restart the round, nor re-enter the lobby. You have to full restart to get the menu back.

DangerRevolution commented 3 weeks ago

Yes, this was also a problem in dde6130 (changelog commit after #994). Not sure how this passed review given this is findable within 5 seconds of interacting with the menu.

FoxxoTrystan commented 3 weeks ago

Reproduction

Enter the Character UI Swap race

Expected behavior

It doesn't do that

Media

2024-10-19.22-25-07.mp4 This happens whether or not you input any text. This does not return if you restart the round, nor re-enter the lobby. You have to full restart to get the menu back.

Custom Specie Name menu should be visible to begin with, as goob MRP (if i think this is where its from) did not enable those.

The name should not show up actully unless enabled, did you enable the CustomName variable?

DangerRevolution commented 3 weeks ago

I found the problem; surprisingly the species prototypes aren't validated. I've renamed the issue to be more accurate.

Aidenkrz commented 3 weeks ago

This should be fixed now