search

Simple-Station / Einstein-Engines

Clearly several people noticed, but who changed the description?
GNU Affero General Public License v3.0
54 stars 154 forks source link

NT faction takes presedence over Syndicate faction for all NPCs/turrets disabling a use case #1228

Open bruhmogus opened 2 weeks ago

bruhmogus commented 2 weeks ago

Description

The Syndicate PDA and ID card faction clothing don't work correctly for one of the intended use cases (crew stealing a PDA to raid the nukie shuttle) since i assume it doesn't disable the NT faction for crew. This likely occurs for other faction clothing (an example would be the carp hardsuit if it was Real)

Reproduction

  1. Equip Syndicate PDA as crew
  2. Go to a Syndicate turret or footsoldier
  3. Die

Expected behavior

  1. Equip Syndicate PDA as crew
  2. Go to a Syndicate turret or footsoldier
  3. Live

Media

20241116065953_1

Additional context

eating a burger with no honey mustard

DocNITE commented 2 weeks ago

I think turrets should be reworked. They should shot you, if have different ID cards, instead of Syndi crew

VMSolidus commented 2 weeks ago

It actually does work(It is correctly adding and removing "Syndicate" faction). The bug is not with the ClothingAddFactionComponent, the bug is with the NpcFactionSystem itself. The turret is shooting characters because they have the Nanotrasen Faction.

We are missing a PR from Wizden that updates the NpcFactionSystem to make it so that the turrets will not shoot people with the Syndicate Faction, regardless of what other factions they have.

bruhmogus commented 2 weeks ago

i wrote this title wrong, the addition of the syndicate pda / id giving faction pr is bugged, not the addition of the faction, this should be open until its actually fixed

VMSolidus commented 2 weeks ago

It is not bugged, the faction is being added correctly.

bruhmogus commented 2 weeks ago

It is not bugged, the faction is being added correctly.

thats what im saying?? i'll rewrite the title