Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
GNU Affero General Public License v3.0
46 stars 123 forks source link

Mirror: Throwing Knives: Syndicate Kit #310

Closed SimpleStation14 closed 3 months ago

SimpleStation14 commented 5 months ago

Mirror of PR #26026: Throwing Knives: Syndicate Kit from space-wizards space-wizards/space-station-14

393bcbfc1346589075ad960473685c78bdbf46e5

PR opened by UbaserB at 2024-03-12 06:57:41 UTC


PR changed 13 files with 101 additions and 8 deletions.

The PR had the following labels:


Original Body

> > > > ## About the PR > > > This PR adds throwing knives and a syndicate bundle in the bundle category for 6 TC which comes with 4 throwing knives in a box. Each knife does 10 slash + 15 pierce damage on throw, and 5 flash per hit (10 DPS). This makes it better than a kitchen knife, but worse than a combat knife, which is what security is fitted with. > > ## Why / Balance > > > This kit is built for weakening an enemy from a distance (from chasing, etc) while being able to fight back if cornered into a 1v1 CQC fight. Sure, you can kill several people with the kit; hence why it's so expensive, but there are drawbacks. Firstly, once it embeds into a target they are able to pull it out. Secondly, when you are pulling them out of a target, YOU are vulnerable. Thirdly, if you miss your hits the target will probably not die. Good things you have four knives and can stab them to death.. better than punches! > > ## Media > > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > **It embeds and kills in 4 throws on an unarmoured target.** > ![image](https://github.com/space-wizards/space-station-14/assets/134914314/05f4112d-a08c-4bde-9b34-8a5ecde0b270) > > **Item description.** > ![image](https://github.com/space-wizards/space-station-14/assets/134914314/87704a6e-8501-4f19-a158-bf89d6b4a83e) > > **4 knives.** > ![image](https://github.com/space-wizards/space-station-14/assets/134914314/44dc4c40-add3-46be-b224-b71e2f14f1e9) > > **Kit on uplink.** > [IMG NEEDS UPDATING] > > **Changelog** > > :cl: Ubaser > - add: You can now purchase a set of 4 throwing knives in the uplink as a bundle for 12 TC.
github-actions[bot] commented 5 months ago

RSI Diff Bot; head commit ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b merging into 4fdfd6fef21def450e2af6617dff0d33d7b1f665 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Storage/boxes.rsi

| State | Old | New | Status | --- | --- | --- | --- | | throwing_knives | ![]() | ![](https://raw.githubusercontent.com/SimpleStation14/Einstein-Engines/ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b/Resources/Textures/Objects/Storage/boxes.rsi/throwing_knives.png) | Added

Resources/Textures/Objects/Storage/boxicons.rsi

| State | Old | New | Status | --- | --- | --- | --- | | throwing_knives | ![]() | ![](https://raw.githubusercontent.com/SimpleStation14/Einstein-Engines/ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b/Resources/Textures/Objects/Storage/boxicons.rsi/throwing_knives.png) | Added

Resources/Textures/Objects/Weapons/Melee/throwing_knife.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-BELT | ![]() | ![](https://raw.githubusercontent.com/SimpleStation14/Einstein-Engines/ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b/Resources/Textures/Objects/Weapons/Melee/throwing_knife.rsi/equipped-BELT.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/SimpleStation14/Einstein-Engines/ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b/Resources/Textures/Objects/Weapons/Melee/throwing_knife.rsi/icon.png) | Added | inhand-left | ![]() | ![](https://raw.githubusercontent.com/SimpleStation14/Einstein-Engines/ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b/Resources/Textures/Objects/Weapons/Melee/throwing_knife.rsi/inhand-left.png) | Added | inhand-right | ![]() | ![](https://raw.githubusercontent.com/SimpleStation14/Einstein-Engines/ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b/Resources/Textures/Objects/Weapons/Melee/throwing_knife.rsi/inhand-right.png) | Added

Edit: diff updated after ac677bad76bc140c8c7e84cb5a85bc36bfb2c92b

VMSolidus commented 5 months ago

why does this overwrite observation kit lol

Because that's just the main downside of how mirrors work. Technically things like this also happen while cherrypicking. I'm trying to work things out with Death and Pspsrite so that full Maintainers can actually make edits to the Mirror PRs to fix issues like these. Trial maintainers should be able to make code suggestions to fix issues like this, and then a full maintainer can come in and hit commit on said suggestions.