search

Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
https://einstein.simplestation.org
GNU Affero General Public License v3.0
28 stars 55 forks source link

Mirror: Restrict door remotes to only being able to manipulate doors relevant to their type #315

Closed SimpleStation14 closed 1 month ago

SimpleStation14 commented 2 months ago

Mirror of PR #26371: Restrict door remotes to only being able to manipulate doors relevant to their type from space-wizards space-wizards/space-station-14

93e3aed26e30375058aa44482236410ff31484f0

PR opened by nikthechampiongr at 2024-03-24 00:28:39 UTC

PR changed 1 files with 3 additions and 8 deletions.

The PR had the following labels:

Original Body

 > > > > ## About the PR > > This makes it so door remotes can no longer manipulate doors just because their user has access to them. > > ## Why / Balance > > Being able to bolt doors and put them on emergency access from a distance is extremely powerful. You should not be able to do it just because you have the access in your id card, it should be limited to the capabilities of the door remote. > > It also makes no sense. > > ## Technical details > > Relevant calls to check for access, and try open/bolt doors had their arguments changed to pass in the door remote instead of the user so now only the door remote's accesses are checked. > > ## Media > > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > > > **Changelog** > > > > :cl: > - tweak: Door remotes can now only control doors specific to their type and do not use the access of their user.
DangerRevolution commented 1 month ago

This is intended to be merged with #357

stellar-novas commented 1 month ago

Hmmm.... I get the intent behind this, but on roleplay servers, I don't think this is abused?

In my experience, remotes don't get stolen that often, so I'm more worried about how this affects legitimate play.

Heads feel no change since their remotes have the same access. Atmos techs lose the ability to set another department's doors to emergency access by giving the remote to a member of that department.

This isn't useful to antags, but it is quite useful to engineers doing work on a department.

This feels like a change made to balance antag issues that aren't as prevalent on roleplay servers, and so it isn't needed here.

(This comment is really shittily written and rambly, I know, but I'm not doing great and it's taken me 20min to write this already, so I'm giving up here)