PR changed 4 files with 7 additions and 2 deletions.
The PR had the following labels:
No C#
Original Body
>
>
>
> ## About the PR
>
> Split Smoke-grenade.ogg into separate prime and detonate sounds. Also converted them from stereo to mono to stop client errors from playing a stereo sound at a position.
>
> ## Why / Balance
>
> Smoke-grenade.ogg covers both the priming sound and the sound of the smoke being released, separated by a few seconds of silence. This is inefficient, and inflexible for changing the fuse length. Separate sounds keep it better synchronized with the action. Additionally, the smoke release part played alongside smoke.ogg, which made a lot of noise. This swaps smoke.ogg for the smoke release part of Smoke-grenade.ogg so there aren't two overlapping sounds.
>
> ## Technical details
>
> I also moved the sounds from Audio/Effects to Audio/Items, since it seems more appropriate, and updated the attributions.yml files accordingly
>
> ## Media
>
> I don't have audio recording with my screen recording setup...
> - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
>
>
> **Changelog**
>
>
>
> Nah
Failed to cherry-pick PR: cannot push non-fastforwardable reference; class=Reference (4); code=NotFastForward (-11)
PR body below
Mirror of PR #26095: Split smoke grenade sound into two parts from
space-wizards/space-station-14
696f97f78ecfb86e4483148588a52e39bf27073cPR opened by
Tayrtahn at 2024-03-13 23:58:41 UTC
PR changed 4 files with 7 additions and 2 deletions.
The PR had the following labels:
> > > > ## About the PR > > Split Smoke-grenade.ogg into separate prime and detonate sounds. Also converted them from stereo to mono to stop client errors from playing a stereo sound at a position. > > ## Why / Balance > > Smoke-grenade.ogg covers both the priming sound and the sound of the smoke being released, separated by a few seconds of silence. This is inefficient, and inflexible for changing the fuse length. Separate sounds keep it better synchronized with the action. Additionally, the smoke release part played alongside smoke.ogg, which made a lot of noise. This swaps smoke.ogg for the smoke release part of Smoke-grenade.ogg so there aren't two overlapping sounds. > > ## Technical details > > I also moved the sounds from Audio/Effects to Audio/Items, since it seems more appropriate, and updated the attributions.yml files accordingly > > ## Media > > I don't have audio recording with my screen recording setup... > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > > > **Changelog** > > > > NahOriginal Body