Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
https://einstein.simplestation.org
GNU Affero General Public License v3.0
28 stars 55 forks source link

Supermatter Engine (Port From White Dream) #341

Open VMSolidus opened 2 months ago

VMSolidus commented 2 months ago

Description

SM boom

New edge supermatter

This PR has been produced in collaboration with coders from White Dream, with written permission given by the relevant code owners to port this specific slice of content to Einstein-Engines. Supermatter Engines are a form of nuclear reactor, which produces energy in the form of radioactive particles, while also decaying into Phoron when excited by an external energy source.

Power can be obtained from the engine via radiation collectors, which like those of a singularity engine, must be periodically refueled. In addition, the engine must also be actively cooled via aid from Atmospherics, and for undesirable gasses to be extracted from the reactor chamber.

If not cooled, the crystal will begin to destabilize and eventually collapse into one of three different situations depending on the source of its instability.

  1. A nuclear blast.
  2. A gravitational singularity
  3. A Tesla ball

Changelog

:cl: VMSolidus, White Dream, Colin-Tel

github-actions[bot] commented 2 months ago

RSI Diff Bot; head commit b44cc4f802d5003fbdc3696d36c1cccb8bc6e992 merging into 2dcab4d57f74e25f4a1aafa23f48463ad6251516 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Supermatter/supermatter.rsi

| State | Old | New | Status | --- | --- | --- | --- | | supermatter | ![]() | ![](https://raw.githubusercontent.com/VMSolidus/Einstein-Engines/b44cc4f802d5003fbdc3696d36c1cccb8bc6e992/Resources/Textures/Supermatter/supermatter.rsi/supermatter.png) | Added

Resources/Textures/Supermatter/supermatter_sliver.rsi

| State | Old | New | Status | --- | --- | --- | --- | | icon | ![]() | ![](https://raw.githubusercontent.com/VMSolidus/Einstein-Engines/b44cc4f802d5003fbdc3696d36c1cccb8bc6e992/Resources/Textures/Supermatter/supermatter_sliver.rsi/icon.png) | Added

Edit: diff updated after b44cc4f802d5003fbdc3696d36c1cccb8bc6e992

VMSolidus commented 2 months ago

TODO LIST:

ESSENTIAL:

Nice to haves that aren't required for this PR, and could in theory be a separate PR:

VMSolidus commented 2 months ago

image

Edge now includes an experimental Supermatter Engine, pending review from Colintel

Colin-Tel commented 2 months ago

After playing around with it for a bit, I am ecstatic thinking about the disasters gameplay that will result from this! I think it looks quite alright on Edge as is, however I think we could afford maybe a few more plasma tanks for the SM area, and I think instead of directing the distro air through the windows on both sides of the "SM command center," we could potentially have the lines both go through the command center instead.

I'm not totally resolute on that second part, as it's nice for the command center to just be a "computers and equipment" area rather than a "we check the physical pipes here too" area. I kind of like the way it's spread out.

So as far as the map is concerned, I am thoroughly enthused. I do think however there could be a distro vent and scrubber in the surrounding chamber, and there could be buttons inside the chamber that open/shut radiation shutters on specific sides.

Colin-Tel commented 2 months ago

Radiation Collectors' "help" button directs them to a guidebook page about the singularity. This would ideally be changed.

VMSolidus commented 2 months ago

New edge supermatter

Edge station has just gotten a new version, courtesy of @Colin-Tel . Thank you for working with us on this project!

DangerRevolution commented 2 months ago

This should also have a render of Edge.yml attached :)

VMSolidus commented 2 months ago

This really should arc to Tesla posts, akin to the Tesla...

the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

DangerRevolution commented 2 months ago

This really should arc to Tesla posts, akin to the Tesla... the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a cope supermatter

VMSolidus commented 2 months ago

This really should arc to Tesla posts, akin to the Tesla... the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

LovelyLophi commented 2 months ago

This really should arc to Tesla posts, akin to the Tesla... the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

I don't see why there couldn't be a scenario that makes the SM arc to tesla posts, would add more variety and options for the engineering team to power the station

DangerRevolution commented 2 months ago

This really should arc to Tesla posts, akin to the Tesla... the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

kinda real, can we re-enable Tesla :)

VMSolidus commented 2 months ago

This really should arc to Tesla posts, akin to the Tesla... the main appeal for saying "Hey, come to EE we have that cool power source from 13!" is that people join, and it's like 13, maybe even expanded. Saying "oh this is kinda, half of what it was in 13" is meh.

I would literally rather close the PR than make it a tesla clone.

why not merge the two :) Tesla is just a SM cope

Tesla can stay SM cope because this is Baystation SM, not /tg/station SM. Being the atmos autism simulator is the main appeal of this version of the engine lol.

kinda real, can we re-enable Tesla :)

Oh absolutely, please do. I would love to see engine variety across maps.

VMSolidus commented 2 months ago

Yea I'm going to leave the minor feature list for a separate PR so that this won't PR bloat harder than it already has. We've deadass included a whole map rework in this PR, I'm not adding 6 new semi-unrelated items in addition to an entire new engine.

VMSolidus commented 2 months ago

Edge-0

VMSolidus commented 2 months ago

Alright ready for review and merge when someone else looks at this.

VMSolidus commented 2 months ago

I've made some updates to Edge based on testing and feedback courtesy of Deep Station and @Peptide90

image

image

WarMechanic commented 1 month ago

It was nice to play with my beloved Supermatter again after so long!

I do have some concerns about the map, I delaminated the SM on my first attempt because I didn't see the pumps in the space loop (they weren't lit up by any lights). Also, the air alarm should be configured at round start to have no vent bounds and for scrubbers to siphon everything (all turned off, of course).

VMSolidus commented 1 month ago

I've just pushed my last update to Supermatter for this PR.

exterior lights waste to coolant

VMSolidus commented 1 month ago

It was nice to play with my beloved Supermatter again after so long!

I do have some concerns about the map, I delaminated the SM on my first attempt because I didn't see the pumps in the space loop (they weren't lit up by any lights). Also, the air alarm should be configured at round start to have no vent bounds and for scrubbers to siphon everything (all turned off, of course).

The first half is something I've just addressed by adding exterior lights for the coolant. The latter however I won't do. There's a convenient note explaining the need to configure the vents and scrubbers.

Colin-Tel commented 1 month ago

Is there any update on this? Just wondering. Still really excited about it.

DangerRevolution commented 1 month ago

Is there any update on this? Just wondering. Still really excited about it.

This is waiting on review from Death or PSprite, PR is done but they're busy I assume.

VMSolidus commented 1 month ago

Is there any update on this? Just wondering. Still really excited about it.

Completely finished, ready to merge, beta testing is complete, and all feedback from said beta tests have been accounted for. I even expanded the code to implement interactions for gas not present on WD's original repo. But since I'm the one who submitted this PR, it can only be merged by either @DEATHB4DEFEAT or @Pspritechologist

whateverusername0 commented 1 week ago

oh no. i think i've messed something up 😬

whateverusername0 commented 1 week ago

OK, i guess it fixed itself 😥

I refactored the SupermatterSystem, cleaned up client and shared stuff, something something

Also made a few additions:

Instead of releasing plasma roundstart, it will start dormant and will activate once something hits it, doesn't matter what exactly.

Now the supermatter crystal will shoot out a single short lightning bolt every insert a certain number of seconds, which scales with the amount of power it currently has. When getting over the PowerThreshold, indicating a delamination into a Tesla, it will shoot 3 overcharged lightning bolts at once. image

It's integrity is now visible via examining it. image

It doesn't speak in the engineering channel anymore, just locally. If one wants it to broadcast to engineering - simply place an intercom there 😃 image

After reaching 50% integrity or less, it will start making public announcements, which should not get very frequent, because it only announces something if it's consistently taking damage. image

When delaminating, if possible, it will set the station alert code either to yellow or delta. Since it's kind of unpreventable, but containable, it's still possible to change the station alert code back if there are crazy engineers who have managed to successfully contain massive spacing, a tesloose or a singuloose. image

Added a new objective for traitors: steal a piece of the supermatter. Simply walk up to it, then cut off a sliver using anything sharp. Takes a lot of time, divides the final countdown timer by 2 and announces the crew that someone has tampered with the crystal. The sliver is also highly radioactive and the glowing makes it nuke-disk-level hard.

Changed some locales, and probably something else that i already forgot about.

DangerRevolution commented 1 week ago

Re-requested @Pspritechologist because the review was fixed; and new changes have been made

whateverusername0 commented 1 week ago

fixed sound handling, station alerts, made tesla coils and grounding rods SM immune for qol also made tesla and singulo SM immune since, when spawning them, they just eat each other and disappear, not desired behavior.