Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
https://einstein.simplestation.org
GNU Affero General Public License v3.0
26 stars 51 forks source link

Alternate Corporate Coats Wave 1 #392

Closed LovelyLophi closed 1 month ago

LovelyLophi commented 1 month ago

Description

Edited the corporate coat by Leonardo DaBepis,

Thought we could have some more options for assistant gang colors. /j


Media

![image](https://github.com/Simple-Station/Einstein-Engines/assets/111106265/2403c399-27ec-42d5-8f3a-2785741cb045) WAOW THEY LOOK SO COOOL RIGHT?


Changelog

:cl:

github-actions[bot] commented 1 month ago

RSI Diff Bot; head commit f6d2035ea8fa523f8264774ae7f708efe418caf7 merging into 156dfb61a88293d99024b784d580fec1ef5a3225 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/OuterClothing/WinterCoats/cs_corpo_jacket.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-OUTERCLOTHING | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/cs_corpo_jacket.rsi/equipped-OUTERCLOTHING.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/cs_corpo_jacket.rsi/icon.png) | Added

Resources/Textures/Clothing/OuterClothing/WinterCoats/ee_corpo_jacket.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-OUTERCLOTHING | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/ee_corpo_jacket.rsi/equipped-OUTERCLOTHING.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/ee_corpo_jacket.rsi/icon.png) | Added

Resources/Textures/Clothing/OuterClothing/WinterCoats/hi_corpo_jacket.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-OUTERCLOTHING | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/hi_corpo_jacket.rsi/equipped-OUTERCLOTHING.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/hi_corpo_jacket.rsi/icon.png) | Added

Resources/Textures/Clothing/OuterClothing/WinterCoats/hm_corpo_jacket.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-OUTERCLOTHING | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/hm_corpo_jacket.rsi/equipped-OUTERCLOTHING.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/hm_corpo_jacket.rsi/icon.png) | Added

Resources/Textures/Clothing/OuterClothing/WinterCoats/id_corpo_jacket.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-OUTERCLOTHING | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/id_corpo_jacket.rsi/equipped-OUTERCLOTHING.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/LovelyLophi/Einstein-Engines/f6d2035ea8fa523f8264774ae7f708efe418caf7/Resources/Textures/Clothing/OuterClothing/WinterCoats/id_corpo_jacket.rsi/icon.png) | Added

Edit: diff updated after f6d2035ea8fa523f8264774ae7f708efe418caf7

LovelyLophi commented 1 month ago

I see the failure, give me a moment.

LovelyLophi commented 1 month ago

Very cool, they look nice; just a question on the meta.json's and

Going to ask for these to be localized in .ftl, which lets downstreams alter the descriptions of these without making merge conflicts for purposes such as translation for our Ukranian fork and altering the description for Syndicate-focused fork so it makes sense in their lore.

@DangerRevolution I have no idea how to do FTL files so I think I'll leave that for other people if they want to pick this up. I'd prefer if there were some solid requirements for what a PR needs that I could read somewhere.

DangerRevolution commented 1 month ago

Very cool, they look nice; just a question on the meta.json's and Going to ask for these to be localized in .ftl, which lets downstreams alter the descriptions of these without making merge conflicts for purposes such as translation for our Ukranian fork and altering the description for Syndicate-focused fork so it makes sense in their lore.

@DangerRevolution I have no idea how to do FTL files so I think I'll leave that for other people if they want to pick this up. I'd prefer if there were some solid requirements for what a PR needs that I could read somewhere.

Very real, localisation should probably be done by script when that's made one day. Standards are something we still have to decide on really, not really sure.

DangerRevolution commented 1 month ago

if you fix the credit by adding your name in i'll approve the review

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

DangerRevolution commented 1 month ago

👍

Just make sure all the tests passes.

they pass, just a microsoft issue