search

Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
https://einstein.simplestation.org
GNU Affero General Public License v3.0
26 stars 51 forks source link

Harpy Peacock Tail #428

Closed VMSolidus closed 1 week ago

VMSolidus commented 1 month ago

Courtesy of @StillIcarus

Description

This adds a new Peacock tail marking to Harpies. I'm also taking this time to update them to the recent DeltaV changes to the birbs.

Media

image image

The backside is semi cursed, but that's something I can't do within the scope of this PR due to sprite system limitations that Death has planned improvements for. Just ignore them. :)

Have a birb as consolation. faridaiscute

:cl: VMSolidus

github-actions[bot] commented 1 month ago

RSI Diff Bot; head commit 5de2a6a03f021c539d3a0ef81ca822f6a91d7502 merging into b04fb6136ea182ffde1a38d4480196d794ad9d51 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/Harpy/harpy_tails48x48.rsi

| State | Old | New | Status | --- | --- | --- | --- | | peacock_tail_eyes | ![]() | ![](https://raw.githubusercontent.com/VMSolidus/Einstein-Engines/5de2a6a03f021c539d3a0ef81ca822f6a91d7502/Resources/Textures/Mobs/Customization/Harpy/harpy_tails48x48.rsi/peacock_tail_eyes.png) | Added | peacock_tail_feathers | ![]() | ![](https://raw.githubusercontent.com/VMSolidus/Einstein-Engines/5de2a6a03f021c539d3a0ef81ca822f6a91d7502/Resources/Textures/Mobs/Customization/Harpy/harpy_tails48x48.rsi/peacock_tail_feathers.png) | Added

Edit: diff updated after 5de2a6a03f021c539d3a0ef81ca822f6a91d7502

github-actions[bot] commented 2 weeks ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

VMSolidus commented 2 weeks ago

These shouldn't be in the DV namespace.

That's right I'm the Harpy maintainer, and I maintain them here. I also commissioned and edited all of the Harpy sprites personally. I have therefore moved the Harpy sprites to the EE folders.

VMSolidus commented 2 weeks ago

Should I just go all the way and migrate the entirety of Harpy code to the EE folders if I am literally the factual author and codeowner of the Birbs?

DangerRevolution commented 2 weeks ago

Should I just go all the way and migrate the entirety of Harpy code to the EE folders if I am literally the factual author and codeowner of the Birbs?

not in this PR

VMSolidus commented 2 weeks ago

Should I just go all the way and migrate the entirety of Harpy code to the EE folders if I am literally the factual author and codeowner of the Birbs?

not in this PR

I'll just leave it at the textures then with this PR. And move the rest later.

github-actions[bot] commented 1 week ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.