PR opened by nikthechampiongr at 2024-03-24 11:57:45 UTC - merged at 2024-03-25 13:20:39 UTC
PR changed 2 files with 14 additions and 3 deletions.
The PR had the following labels:
Status: Needs Review
Original Body
> fixes #18275
>
>
>
> ## About the PR
>
> This fixes mailing units appearing as disposal units when flushed.
>
> ## Technical details
>
> The states were hardcoded.
>
> Now they are not.
>
> Bug seems to have been introduced in #17803 as a part of a larger refactor on disposal units. To my understanding, this was made in error with the logic that no other objects would ever have a different animation when flushing and charging but I am not sure.
>
> ## Media
>
>
> - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase
>
> **Changelog**
>
>
>
> :cl:
> - fix: Mailing units no longer spontaneously turn into disposal units when flushed.
Mirror of PR #26383: Fix mailing units turning into disposal units while recharging. from
space-wizards/space-station-14
94e4755a8de6885c97fac1cfb767144e8e07981aPR opened by
nikthechampiongr at 2024-03-24 11:57:45 UTC - merged at 2024-03-25 13:20:39 UTC
PR changed 2 files with 14 additions and 3 deletions.
The PR had the following labels:
> fixes #18275 > > > > ## About the PR > > This fixes mailing units appearing as disposal units when flushed. > > ## Technical details > > The states were hardcoded. > > Now they are not. > > Bug seems to have been introduced in #17803 as a part of a larger refactor on disposal units. To my understanding, this was made in error with the logic that no other objects would ever have a different animation when flushing and charging but I am not sure. > > ## Media > > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > **Changelog** > > > > :cl: > - fix: Mailing units no longer spontaneously turn into disposal units when flushed.Original Body