search

Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
https://einstein.simplestation.org
GNU Affero General Public License v3.0
24 stars 49 forks source link

Port Parkstation Audio Library #457

Open VMSolidus opened 2 weeks ago

VMSolidus commented 2 weeks ago

Description

By request from @DEATHB4DEFEAT , this ports https://github.com/Simple-Station/Parkstation/pull/55

:cl: VMSolidus

github-actions[bot] commented 2 weeks ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

VMSolidus commented 2 weeks ago

I assume this changes sounds as needed? Also; Shadowkin sounds? Are we porting those?

Yes, we are. :)

DEATHB4DEFEAT commented 2 weeks ago

I assume this changes sounds as needed? Also; Shadowkin sounds? Are we porting those?

Yes, we are. :)

What for?

VMSolidus commented 1 week ago

I assume this changes sounds as needed? Also; Shadowkin sounds? Are we porting those?

Yes, we are. :)

What for?

Audio library objects can be re-used and modified to suit other purposes, so of all the assets to store upstream, they're one of the most sensible. Even if Shadowkin aren't upstreamed to EE, having the audio files here still makes sense. Plus it was just part of the original PR that I cherrypicked here.

DEATHB4DEFEAT commented 5 days ago

While playing, I noticed the cup pickup sound is very loud. #474 :) I don't remember any other issues, might properly review this later but doesn't matter.