Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
https://einstein.simplestation.org
GNU Affero General Public License v3.0
24 stars 49 forks source link

Invert the Running/Walking States #485

Open DEATHB4DEFEAT opened 5 days ago

DEATHB4DEFEAT commented 5 days ago

Description

Ports https://github.com/Simple-Station/Parkstation-Friendly-Chainsaw/pull/39

A change made to encourage people to stop and smell the roses, instead of sprinting everywhere trying to get shit done. This goes well with #486, so people don't actually have to rush places to try to get things done before the shift ends fatally. It's weird anyway how we're all constantly sprinting everywhere and have to very actively choose not to (and why would you?). Increases the default speeds so that walking isn't painfully slow and sprinting feels more like sprinting in combination with the active choice to sprint.

Someone needs to PR changing the default sprint or examine buttons, so people can fight and sprint with this change. (A lot of other default keybinds suck or conflict too and need to change)

Changelog

:cl:

FoxxoTrystan commented 5 days ago

Im not a fan of this change, i like the shift to slow down because else mostly nearly everyone is going to hold shift to just walk, and that just may be annoying.

DEATHB4DEFEAT commented 5 days ago

Im not a fan of this change, i like the shift to slow down because else mostly nearly everyone is going to hold shift to just walk, and that just may be annoying.

Use toggle sprint or slow down and enjoy The Park.

DEATHB4DEFEAT commented 5 days ago

My main concern here is that there should be a note somewhere of how to reverse this change; or maybe making this a CVAR although I assume since this isn't a CVAR it's hard to do.

Not a very easy thing to CVar, but probably doable. If you want to reverse this change, revert this PR.

DangerRevolution commented 5 days ago

My main concern here is that there should be a note somewhere of how to reverse this change; or maybe making this a CVAR although I assume since this isn't a CVAR it's hard to do.

Not a very easy thing to CVar, but probably doable. If you want to reverse this change, revert this PR.

A comment in the CVar file will be more than enough :) Similar to the trade station

Leave making it a CVAR as a TODO

DEATHB4DEFEAT commented 5 days ago

Added a description explaining rationale.

DangerRevolution commented 4 days ago

This is directly messing with input code - should be either behind a CVAR with the default being false or toggleable by the user. Game is made to be fast-paced, indicative by multiple (emergent) mechanics, like slipping speed or reflect thresholds.

Above is very true; but default should be set to true

github-actions[bot] commented 3 days ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.