search

Simple-Station / Einstein-Engines

A Space Station 14 upstream repository, inspired by Baystation12.
GNU Affero General Public License v3.0
53 stars 140 forks source link

Listening Outpost Adds Gamerules #764

Closed ShatteredSwords closed 2 months ago

ShatteredSwords commented 2 months ago

Description

Listening Outpost starts Traitor Gamemode also also starts an event scheduler?

Reproduction

  1. Listening Outpost Spawns
  2. Someone picked the Listening Outpost ghost role
  3. Traitor Gamerule Starts
  4. Possibly also starts an event scheduler

Expected behavior

  1. Listening Outpost Spawns
  2. Someone picks the Listening Outpost ghost role
  3. Gamerules stay the same (other than the listening outpost)

Additional context

This was/is an issue in DeltaV, and I have no idea if they've solved it there or not

VMSolidus commented 2 months ago

This was an issue on this codebase, until we reverted the Antag Refactor cherry-pick. We'll revisit antag refactor at a later time when we are ready to actually do another mass cherry-pick. DeltaV does have fixes for the Listening Outpost for the Antag Refactor, and we'll likely cherry-pick said fixes when the time is right.