search

Simple-Station / Einstein-Engines

Nobody will ever notice I changed the repository description, right?
GNU Affero General Public License v3.0
54 stars 149 forks source link

Enemies and Allies Content Port #956

Closed fenndragon closed 1 month ago

fenndragon commented 1 month ago

Description

This is a batch of changes I made for Floof station being ported over to the upstream branch

Changelog

:cl:

github-actions[bot] commented 1 month ago

RSI Diff Bot; head commit 28d3e2b24331c436cc59bd04a91e8a53a3817178 merging into b53b555612fc2c74a978007b5e46affbdaf36794 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi

| State | Old | New | Status | --- | --- | --- | --- | | crit | ![](https://raw.githubusercontent.com/Simple-Station/Einstein-Engines/b53b555612fc2c74a978007b5e46affbdaf36794/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/crit.png) | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/crit.png) | Modified | dead | ![](https://raw.githubusercontent.com/Simple-Station/Einstein-Engines/b53b555612fc2c74a978007b5e46affbdaf36794/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/dead.png) | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/dead.png) | Modified | running | ![](https://raw.githubusercontent.com/Simple-Station/Einstein-Engines/b53b555612fc2c74a978007b5e46affbdaf36794/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/running.png) | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/running.png) | Modified | sleeping | ![](https://raw.githubusercontent.com/Simple-Station/Einstein-Engines/b53b555612fc2c74a978007b5e46affbdaf36794/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/sleeping.png) | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi/sleeping.png) | Modified

Resources/Textures/Mobs/Animals/patriarch.rsi

| State | Old | New | Status | --- | --- | --- | --- | | patriarch | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/patriarch.rsi/patriarch.png) | Added | patriarch_crit | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/patriarch.rsi/patriarch_crit.png) | Added | patriarch_dead | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/patriarch.rsi/patriarch_dead.png) | Added | patriarch_sleeping | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/patriarch.rsi/patriarch_sleeping.png) | Added

Resources/Textures/Mobs/Animals/subject7355.rsi

| State | Old | New | Status | --- | --- | --- | --- | | glow | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/subject7355.rsi/glow.png) | Added | subject7355 | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/subject7355.rsi/subject7355.png) | Added | subject7355_crit | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/subject7355.rsi/subject7355_crit.png) | Added | subject7355_dead | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/subject7355.rsi/subject7355_dead.png) | Added | subject7355_sleeping | ![]() | ![](https://raw.githubusercontent.com/fenndragon/Avalon/28d3e2b24331c436cc59bd04a91e8a53a3817178/Resources/Textures/Mobs/Animals/subject7355.rsi/subject7355_sleeping.png) | Added

Edit: diff updated after 28d3e2b24331c436cc59bd04a91e8a53a3817178

fenndragon commented 1 month ago

The entire changelog should be just 1-2 entries, and should not include technical details.

better?

Mnemotechnician commented 1 month ago

It should also be descriptive for someone who's reading it in the menu. "Added new neutral xeno prototypes for admins to use in events" or something similar would be good.

fenndragon commented 1 month ago

It should also be descriptive for someone who's reading it in the menu. "Added new neutral xeno prototypes for admins to use in events" or something similar would be good.

I listed a bit better what all was added but I did it in one entry, better?

fenndragon commented 1 month ago

Except for Rouney Sprite, i dont think those additions are needed.

Those Neutral things were things you done mostly for floof, il let solidus view it.

it was requested.

fenndragon commented 1 month ago

Except for Rouney Sprite, i dont think those additions are needed.

Those Neutral things were things you done mostly for floof, il let solidus view it.

Also, how is additional events and reagent slimes not needed? this is literally just additional content.

VMSolidus commented 1 month ago

Or well, it would be when the Linter fail is fixed. That's legitimate.

fenndragon commented 1 month ago

Or well, it would be when the Linter fail is fixed. That's legitimate.

whoops forgot to change the texture paths, my bad

fenndragon commented 1 month ago

went ahead and just added 3 more events and fixed the event text in the locale while I was thinking about it

fenndragon commented 1 month ago

New Events in general just remove all the uniquness of anomalies that can spawn it ect... And some of them does not fit, i would not approve something like this, review goes to others for it.

that's fine, and I was going to leave it at that but it was then requested as a feature personally by others to port it upstream so that's what I'm doing.