search

Simple-Tracker / qBittorrent-ClientBlocker

一款适用于 qBittorrent/Transmission (Beta)/BitComet (Beta, Partial) 的客户端屏蔽器, 默认屏蔽包括但不限于迅雷等客户端. A client blocker compatible with qBittorrent/Transmission (Beta)/BitComet (Beta, Partial) which is prohibited to include but not limited to clients such as Xunlei.
MIT License
1.02k stars 26 forks source link

Allow skipping SSL cert verification #15

Closed gyakkun closed 8 months ago

gyakkun commented 8 months ago

Thank you for your great work. What I encounter is, my qBittorrent exposes https port directly rather than behind a reverse proxy, and its certificate expired long time ago : ) so the blocker alerts me "tls: failed to verify certificate: x509: certificate signed by unknown authority."

This PR simply adds a config item to allow skipping SSL certificate verification.

Simple-Tracker commented 8 months ago

感谢 PR!

看起来很不错, 我会合并它, 不过有关于编码风格 (及编码规范) 类的东西我暂时不想动它 (1 是与个人编码的不良习惯有关; 2 是其它所有文件都有涉及, 单独改一个部分会造成不统一). 另外, 有计划将 TlsSkipCertVerification 修改为 SkipCertVerification.

若有相关问题, 可于此 PR 继续追加.

Thanks for the Pull Request!

It looks very good for me, I will merge it, but there are things about coding style (or coding standards) that I don’t want to touch for the time being (1 is related to personal bad coding habits; 2 is that all other files/modules are involved and should be changed separately One part will create disunity). In addition, there are plans to modify TlsSkipCertVerification to SkipCertVerification.

If you have any related questions, you can continue to add them to this PR.

Simple-Tracker commented 8 months ago

2.7b4 (另: GitHub Action 构建失败是配置问题, 不影响实际功能可用性)