search

SimpleBrowserDotNet / SimpleBrowser.WebDriver

A webdriver for SimpleBrowser
Apache License 2.0
43 stars 16 forks source link

SimpleNavigate now supports handling `Back()` #1

Closed spoike closed 12 years ago

spoike commented 12 years ago

SimpleNavigate now has a history to go back. Implemented using a Stack of strings.

Had to refactor SimpleNavigate to take an IBrowser instead of SimpleBrowserDriver so I could easily write tests to it.

spoike commented 12 years ago

Added support for Forward() method as well.

Teun commented 12 years ago

Question: do you feel that the driver should fake history management and let the automated browser do "normal" navigation? Or should the browser really implement a history stack and the driver just forward the calls to it?

spoike commented 12 years ago

Ideally the browser should handle history itself. Right now it is a hack in case you need it. You might argue YAGNI but it was easy to implement. ;)

Hmm... I pushed in some commits that were not supposed to be in this pull request, making the nuget spec... but it added the commits automatically.

Teun commented 12 years ago

Cherry picked your commits for history. Thanks.