search

SimpleBrowserDotNet / SimpleBrowser.WebDriver

A webdriver for SimpleBrowser
Apache License 2.0
43 stars 16 forks source link

Why having two separate nuget packages (SimpleBrowser and SimpleBrowser.Webdriver) #28

Closed AndersBillLinden closed 7 years ago

AndersBillLinden commented 10 years ago

Why are SimpleBrowser and SimpleBrowser.Webdriver two separate projects?

Teun commented 10 years ago

Well. Nathan was the owner of SimpleBrowser (not very active at the time). I needed a basic .NET headless browser from my WebDriver tests. So I started on a driver. Only later I got involved in SimpleBrowser myself.

I think that many people use SimpleBrowser without WebDriver btw. Op 31 aug. 2014 21:26 schreef "Anders Lindén" notifications@github.com:

Why are SimpleBrowser and SimpleBrowser.Webdriver two separate projects?

— Reply to this email directly or view it on GitHub https://github.com/Teun/SimpleBrowser.WebDriver/issues/28.

AndersBillLinden commented 10 years ago

Is it possible to see how many that have nugetted SimpleBrowser but not SimpleBrowser.Webdriver?

Teun commented 10 years ago

You can have a look at rhe download stats on nuget.org. Op 31 aug. 2014 23:15 schreef "Anders Lindén" notifications@github.com:

Is it possible to see how many that have nugetted SimpleBrowser but not SimpleBrowser.Webdriver?

— Reply to this email directly or view it on GitHub https://github.com/Teun/SimpleBrowser.WebDriver/issues/28#issuecomment-54001571 .

AndersBillLinden commented 10 years ago

Hm, 5130 downloads of SimpleBrowser and 3601 downloads of SimpleBrowser.WebDriver. I found a logical reason to have the projects merged as one project when I was modifying SimpleBrowser to disallow file urls in a non file url document and found out that it would be the easiest to create a test for the change in SimpleBrowser.WebDriver. Which is not really a good place to put code that test things in SimpleBrowser.

kevingy commented 7 years ago

I realize this is an old thread, but in the interest of closing old issues...

Why are SimpleBrowser and SimpleBrowser.Webdriver two separate projects?

The better question is why do they need to be combined?

I found a logical reason to have the projects merged as one project when I was modifying SimpleBrowser to disallow file urls in a non file url document and found out that it would be the easiest to create a test for the change in SimpleBrowser.WebDriver.

Let me repeat what you just said, a different way, just to see if I understand you. You are suggesting that we combine the two SimpleBrowser products into one just so that a feature modified in SimpleBrowser can be more easily tested using SimpleBrowser.WebDriver. That's the equivalent of saying let's combine Microsoft Word and Microsoft PowerPoint, because I modified the way spell checking works in Word, but it's easier to test in PowerPoint. That's ridiculous.

As is typical, the easiest solution isn't the best solution.

Teun commented 7 years ago

Also, I don't really see how it is easier. If you install the package SimpleBrowser.WebDriver, it will also install the version of SimpleBrowser it depends on. If your test is testing something in SimpleBrowser, the test should live there.

AndersBillLinden commented 7 years ago

As I remember it, the two projects does not make sense without each other. Anyone developing in one of the repos would be sure to have checked out the other as well (that fact alone is a signal that maybe they should be combined). The repos are not huge, there is no code mass. There is no relief splitting them in two. A motivator to split a repo in two must be some other logical reason. A reason I am asking about in this issue. The easiest solution should always be considered.

kevingy commented 7 years ago

Anyone developing in one of the repos would be sure to have checked out the other as well

This is a false statement. I have used SimpleBrowser for years. I have never used SimpleBrowser.Webdriver.

There is no relief splitting them in two.

No one has split them into two. SimpleBrowser and SimpleBrowser.WebDriver started as two separate and independent projects. It's actually more work to combine them. That effort that is better spent working on real problems.

If you look at the top three browsers - Chrome, Internet Explorer, and Firefox, all of them work exactly the way SimpleBrowser works. The browser is separate from the browser's corresponding WebDriver. It doesn't make sense for SimpleBrowser to deviate.

I think between Teun and myself, there's enough consensus to close this issue. Thank you for your suggestion, but this will not be implemented.