search

SimpleBrowserDotNet / SimpleBrowser.WebDriver

A webdriver for SimpleBrowser
Apache License 2.0
43 stars 16 forks source link

Updating to WebDriver 3.14 #40

Closed barancev closed 6 years ago

kevingy commented 6 years ago

@Teun I'll let you handle this pull request. You are more familiar with the WebDriver than I am.

Teun commented 6 years ago

I will have a look and leave some comments were appropriate, but frankly, I hardly feel ownership of this library anymore. I started it many years ago and have not used it myself for at least three years. I don't even have a development environment available were I can compile and test.

So maybe someone else feels like taking some responsibility here? Maybe Alexei, who apparently want the library to at least be updated to later versions of dependencies, can step in?

barancev commented 6 years ago

I have no plan to take ownership of this project, sorry, my primary area of interests is not related to .Net, this PR is just a side-effect of a short contract with a customer that wanted .Net, but I'm already out.

Teun commented 6 years ago

Right. Fair enough, one can always hope.

Teun commented 6 years ago

So I merged this pull request into a separate branch (barancev-master) and ran the CI build over it (this was last done very long ago, so I had to fix some things in the environment as well).

It has 4 failing unit tests. You can see the full build result here: https://teamcity.jetbrains.com/viewLog.html?buildId=1643817&buildTypeId=bt1121&tab=buildResultsDiv (there is a "Login as guest" button)

Not sure what to do with this. As the code does hardly involve any real changes, I assume that these failing tests are caused by changes in the underlying dependencies (Selenium? Moq?). We can just mute these tests for now and publish a new version. That will at least allow people to work with it using up-to-date SimpleBrowser and Selenium.

Teun commented 6 years ago

Pff. That took more than I thought to get all those CI steps up-to-date and running again. But it is fine now. New version has been published as 0.5.43.

Why the 4 unit tests are failing, I don't know. I would nee a .NET 4 environment to figure it out.