search

SimpleITK / SimpleITKPythonPackage

A setup script to generate a Python Wheels
17 stars 11 forks source link

Use submodule for SimpleITK source code directory #14

Closed blowekamp closed 7 years ago

blowekamp commented 7 years ago

Instead of a download step include the SimpleITK source code as part of the repository via a git submodule. This should aid in source code packaging.

blowekamp commented 7 years ago

@jcfr I was hoping this would make sdist include the SimpleITK source code. Here is the output:

$ python setup.py sdist
running sdist
running generate_source_manifest
running check
reading manifest file 'MANIFEST'
creating SimpleITK-0.11.0
creating SimpleITK-0.11.0/scripts
creating SimpleITK-0.11.0/scripts/internal
making hard links in SimpleITK-0.11.0...
hard linking .gitignore -> SimpleITK-0.11.0
hard linking .gitmodules -> SimpleITK-0.11.0
hard linking CMakeLists.txt -> SimpleITK-0.11.0
hard linking README.md -> SimpleITK-0.11.0
'SimpleITK' not a regular file -- skipping
hard linking requirements-dev.txt -> SimpleITK-0.11.0
hard linking setup.py -> SimpleITK-0.11.0
hard linking scripts/dockcross-manylinux-build-wheels.sh -> SimpleITK-0.11.0/scripts
hard linking scripts/internal/manylinux-build-wheels.sh -> SimpleITK-0.11.0/scripts/internal
hard linking scripts/internal/manylinux-libpython-not-needed-symbols-exported-by-interpreter -> SimpleITK-0.11.0/scripts/internal
hard-linked 10 files
creating 'dist/SimpleITK-0.11.0' gztar archive and adding 'SimpleITK-0.11.0' to it
Creating tar archive
removing 'SimpleITK-0.11.0' (and everything under it)
blowekamp commented 7 years ago

Getting packing of the source code with the SimpleITK source code is an important blocker. The intention of adding SimpleITK as a submodule is to help support that. Can this be done with scikit-build?