cmake: Set CMAKE_BUILD_TYPE to Release if none was specified

SimpleITK / SimpleITKPythonPackage

A setup script to generate a Python Wheels

17 stars 11 forks source link

Closed jcfr closed 7 years ago

blowekamp commented 7 years ago

Thank you for the patch!

I believe that scikit-build default sets the BUILD_TYPE to release?

blowekamp commented 7 years ago

The SimpleITK-python was missing ep_common_cmake_cache_args.

Looks good to me now

jcfr commented 7 years ago

If this was C++ would we not get these default properties?

No. It is the responsibility of the build system developer to propagate them.

The SimpleITK-python was missing ep_common_cmake_cache_args. Looks good to me now

I will merge.