search

SimpleITK / SlicerSimpleFilters

A Module for Slicer3D to provide a simple GUI to image filters from the Insight Toolkit.
Other
1 stars 12 forks source link

BUG: Fix python3 incompatibilities for file and exec calls #18

Closed jamesobutler closed 5 years ago

jamesobutler commented 5 years ago

This should close #17.

@blowekamp Please review and test using some filters. The changes made related to the exec call differences between python2 and python3 were made based on reading this stackoverflow https://stackoverflow.com/questions/15086040/behavior-of-exec-function-in-python-2-and-python-3. The code here is a little out of the ordinary and I'm not super familiar with the exec call.

jcfr commented 5 years ago

I suggest we push an other commit on top this PR: https://github.com/SimpleITK/SlicerSimpleFilters/pull/19

Ps: I didn't notice your PR only after I finalized mine ...

jamesobutler commented 5 years ago

Looks like you went ahead and replaced the exec calls which is even better and made some other necessary changes so that’s fine by me!

blowekamp commented 5 years ago

Thank you so much for your work on this. The conciseness appears to be to go with PR#19.