search

SimpleMachines / SMF

Simple Machines Forum — SMF in short — is free and open-source community forum software, delivering professional grade features in a package that allows you to set up your own online community within minutes!
https://www.simplemachines.org/
Other
586 stars 253 forks source link

Three different login displays: inconsistent? #2187

Closed ChainyEO closed 10 years ago

ChainyEO commented 10 years ago

Is it a good idea to have three different ways of displaying the login? Maybe it would be better to stick with one?

We currently have:

  1. Popup box: login popup
  2. Dropdown box: login_dropdown1
  3. Traditional login display:

traditional login

XinYenFon commented 10 years ago

Actually 2 & 3 same. and first one getting some part of 3, not inconsistency :P

XinYenFon commented 10 years ago

Can we close this? There is no inconsistency in it. This is how its designed. To clear things, those popup login boxes are not actually coded, they are taken from login action. So we either need to change login popup to take more of that page (which is not needed) or rewrite the login action UI. None of those really needed and not worth it.

NegativeIQ commented 10 years ago

Yeah 1 and 2 are actually ONE (thats actually fast/quick login from older versions than 2.1) and 3 is actual login page. If your credentials are not accepted than you will be redirected to 3 where possible errors will be displayed.

ChainyEO commented 10 years ago

Just an extra note as I'm not sure you understood the point I was trying to make.

1 and 2 are apparently drawn from the same code, but they are still displayed on the page in different ways. Version 1 is shown in the drop-down menu when you click on items in "Username/My Messages/Alerts", whereas version 2 is displayed as a pop-up. How about displaying both of these as a pop-up? (maybe a pop-up could also replace the third version, too?).

The point I was trying to make was one of consistency. I don't necessarily support the idea of the pop-up version being used everywhere, but I think it might be good to stick to one display method.

live627 commented 10 years ago

oh I get it, however, the top drop downs only show login forms in abnormal situations. In theory, anyway...

On Tue, Aug 19, 2014 at 1:56 AM, Chainy notifications@github.com wrote:

Just an extra note as I don't think you understood the point I was trying to make.

1 and 2 are apparently drawn from the same code, but they are still displayed on the page in a different way. Version 1 is shown in the drop-down menu when you click on items in "Username/My Messages/Alerts", whereas version 2 is displayed as a pop-up. How about displaying both of these as a pop-up? (maybe a pop-up could also replace the third version, too?).

The point I was trying to make was one of consistency. I don't necessarily support the idea of the pop-up version being used everywhere, but I think it might be good to stick to one display method.

— Reply to this email directly or view it on GitHub https://github.com/SimpleMachines/SMF2.1/issues/2187#issuecomment-52606867 .