search

SimpleMachines / SMF

Simple Machines Forum — SMF in short — is free and open-source community forum software, delivering professional grade features in a package that allows you to set up your own online community within minutes!
https://www.simplemachines.org/
Other
583 stars 252 forks source link

"Show most recent posts at the top" causes weird issues #6270

Closed Oldiesmann closed 3 years ago

Oldiesmann commented 3 years ago

Description

Kind of hard to describe this but the "Show most recent posts at the top" setting (under "Look and Layout" in the profile) causes weird issues. This was reported by a member of my seniors forum and I was able to reproduce it by testing a few things...

On my test board (running latest git build as of this posting): Replying to a topic results in only the first post in the topic being shown (though the post number is correct) The link to the latest post in the topic is incorrect on the board index (for instance, in one topic it shows .../index.php?topic=3.msg23#new but the highest post ID is 22)

Also, on the seniors forum, I've found that some posts get cut off. For instance, in one topic, the most recent post was made earlier today but when I go directly to that topic (eg .../index.php?topic=x.0) it doesn't show anything newer than July 20th.

Steps to reproduce

  1. Go to Profile -> Look and Layout and check the box marked "Show most recent posts at the top in topic view"
  2. Post and browse the forum like usual

Environment (complete as necessary)

Additional information/references

Seniors forum: https://www.seniorsandfriends.org Test board: https://smfgit.oldiesmann.us Seniors board is running solely on nginx while the test board is Apache with nginx reverse proxy Caching is at level 1 using APCu, but disabling caching doesn't make a difference in the outcome

dragomano commented 3 years ago

Display.php, try to comment out these lines: from 867 to 895.

SychO9 commented 3 years ago

Same as #5764 ?

Oldiesmann commented 3 years ago

Same as #5764 ?

@albertlast seems to think so. I haven't encountered any database errors though.

SychO9 commented 3 years ago

the database error is just one symptom, a lot of weird things happen with this one setting, all due to the same problem. Hence why I think this is most likely a duplicate issue

Butterflysaway commented 3 years ago

Why not just remove the option permanently? I've removed it from mine. Could do a PR if you want.

sbulen commented 3 years ago

I think it's a very handy option - especially for mobile browsing. It makes it much easier to see the latest & greatest.

I use it, & the question comes up on my forum from time to time, so I know my users use it also.

SychO9 commented 3 years ago

yea, I've seen from other communities where I was around that it is a very used option, so I think trying to fix it would be better than directly removing it.

MissAllSunday commented 3 years ago

Indeed it looks like a duplicate, as such will close this one. Please lets continue on the original issue: #5764