search

SimpleMachines / SMF

Simple Machines Forum — SMF in short — is free and open-source community forum software, delivering professional grade features in a package that allows you to set up your own online community within minutes!
https://www.simplemachines.org/
Other
600 stars 255 forks source link

Cannot change "reason for editing" text in quick edit mode #7642

Open Turrican3 opened 1 year ago

Turrican3 commented 1 year ago

Description

Apparently the small explaining text that can be added when the grace period has expired cannot be changed in quick edit mode (i.e. modifications don't get saved)

Steps to reproduce

  1. wait for the grace period to expire
  2. try to add or change the explanation text in quick edit mode

Environment (complete as necessary)

Additional information/references

Haven't checked as regular user yet, only admin. To actually save changes to the database I have to switch to standard edit mode. Happens on both my posts and other users post.

DiegoAndresCortes commented 1 year ago

This is intentional and has always been like that. Perhaps could be added in a future release.

Turrican3 commented 1 year ago

Whooops sorry, I've been using SMF 2.1.x for quite a few months now but I hadn't noticed that yet.

To be honest I find this behaviour a bit confusing since the text is there and can be edited... but it's definitely a minor issue, nothing to worry about.

Thanks!

DiegoAndresCortes commented 1 year ago

I now understand this, definitely an issue... This is a visual issue only, the reason is displayed even though nothing changed.

Turrican3 commented 1 year ago

I stand corrected (or changes have been made to the code, I don't know)

Currently, I can add explanation text even after grace period has expired in quick edit mode.

But this text cannot be changed in quick edit mode afterwards, you must switch to full edit mode for changes to be applied.

DiegoAndresCortes commented 1 year ago

I see, that could be adjusted as well, to instead match the behavior of the full modify. I will have a look later.