search

SimpleMachines / SMF

Simple Machines Forum — SMF in short — is free and open-source community forum software, delivering professional grade features in a package that allows you to set up your own online community within minutes!
https://www.simplemachines.org/
Other
595 stars 255 forks source link

Quote selected text does not parse `[member]` BBC #7837

Closed live627 closed 11 months ago

live627 commented 1 year ago

The fix is to change the output in parse_bbc

from

<a class="mention" href="https://www.simplemachines.org/community/index.php?action=profile;u=154736">@live627</a>

to

<a data-mention="154736" data-type="mention" class="mention" href="https://www.simplemachines.org/community/index.php?action=profile;u=154736">@live627</a>
jdarwood007 commented 1 year ago

This was broken in 2.1.3. It was mentioned in the beta topic (msg 4138946) and I mentioned that fix.

SCeditor needs changed to do

            return '<a href="' + smf_scripturl +'?action=profile;u='+ attrs.defaultattr + '" class="mention" data-type="mention" data-mention="'+ attrs.defaultattr + '">@'+ content.replace('@','') +'</a>';

The bug was introduced in #7463

live627 commented 1 year ago

From https://www.simplemachines.org/community/index.php?topic=584161.0

I believe this is a different, unreported, issue.