search

SimpleMachines / smf-mw-auth

SMF MediaWiki Authentication
https://www.simplemachines.org
Other
23 stars 18 forks source link

$user->setupSession(); to wfSetupSession(); #1

Closed jdarwood007 closed 12 years ago

jdarwood007 commented 12 years ago

According to Paracelsus, in MW 1.18, they changed the following code:

$user->setupSession();
$user->setCookies();

Will need to research this.

Fustrate commented 12 years ago

Not knowing mediawiki, there are two things that come to mind. Either use a version variable if MW provides one, or do a function_exists('wfSetupSession') and proceed from there. Do we know if $user->setCookies() also changed, probably to wfSetCookies()?

Also, is sm.org going to upgrade to 1.18, or is there a test installation somewhere? That would be the quickest way to solve this.

jdarwood007 commented 12 years ago

Well at least in 1.17 the method in the User class is as follows:

/**
 * @deprecated Use wfSetupSession().
 */
function SetupSession() {
    wfDeprecated( __METHOD__ );
    wfSetupSession();
}

So we should be able to safely replace this since it was finally removed.

Cookies have not changed.