search

SimpleMachines / smf-mw-auth

SMF MediaWiki Authentication
https://www.simplemachines.org
Other
23 stars 18 forks source link

500 Internal Server Error with v1.24.0 #8

Closed Tokzu-zz closed 6 years ago

Tokzu-zz commented 9 years ago

Hello,

This morning I upgraded my MediaWiki to 1.24.0 but I received an 500 Internal Server Error and in my error log is is displayed:

20141127T130128: wiki.kaero-webs.com/index.php PHP Fatal error: Cannot access protected property User::$mOptionOverrides in /wiki/extensions/Auth_SMF.php on line 1050

Maybe is because the new version, by the way in 1.23 I don't have this problem.

sagnitude commented 8 years ago

Modify wiki/includes/User.php:

search for protected $mOptionOverrides;

replace it with public $mOptionOverrides;

this shall fix it.

jdarwood007 commented 8 years ago

I wonder what they changed that caused this.

https://git.wikimedia.org/blob/mediawiki%2Fcore/HEAD/includes%2FUser.php Looking at their git repo, the User class hasn't changed from what I see to cause that.

sagnitude commented 8 years ago

The change was introduced in this commit:

https://git.wikimedia.org/commitdiff/mediawiki%2Fcore/2daa1fab7a200ac2045e1e03e17a19fea1792afe

It seems they were trying to drop support for PHP 4.4 which doesn't support the keyword 'protected'.

jdarwood007 commented 7 years ago

@sagnitude Is this still an issue?

jdarwood007 commented 6 years ago

Closing this as we are targeting 1.27 at this point and will support future releases. 1.24 is EOL for MediaWiki