search

SimpleMachines / tools

Tools for SMF: useful scripts, install/repair and others.
22 stars 34 forks source link

Bug Board List - Repair Settings #11

Closed XinYenFon closed 10 years ago

XinYenFon commented 10 years ago

Beside opening four new issue, I decided to move all into one position. (Didn't test)

When it shows the mysql password it does't see semi colons. So if my password is isag;@%as the input box says it is invalid and only shows isag.

So I've been working on a little site that I wanted to launch, anyway, the DB password has a " in it.

repair_settings.php chops the password off, making it impossible to actually use, and even if you manually override it each time with the new password, the saved password in Settings.php escapes the " - but since it's inside ' the escape character is included as a literal, so that doesn't work either.

The new & improved version of repair_settings.php cannot be used to repair database settings. If db settings are incorrect, the script crashes with a screenfull of mysql errors. The new bit that's supposed to fix theme settings tries to run mysql functions without a db connection.

Not a major problem, just ran into it for first time, but repair_settings.php doesn't work if there's a semicolon in the database password. It cuts off the ; and everything following, and can't connect to the db. The forum does not have a problem with it.

illori commented 10 years ago

i believe that a good bit of this has been resolved with #10

XinYenFon commented 10 years ago

Sorry to clean bug board, i just moved them w/o testing, better @margarett looks at the list.

margarett commented 10 years ago

Point 3 is fixed in my commit.

The database password being cropped was discussed by emanuele some time ago. I think one of the password issues is fixed already, either the semicolon or the single quote. I just don't know which. I will test it and check ;)

margarett commented 10 years ago

I can confirm that the double quote still breaks database password, just had that experience today.

margarett commented 10 years ago

All issues should now be fixed with #12 :wink:

illori commented 10 years ago

then we can get this closed?